Skip to content

fix(gateway): Enable Gateway plugin build for 2026.1#6342

Merged
eliseong merged 1 commit intofeature/toolkitOnlyfrom
fixGateway
Apr 7, 2026
Merged

fix(gateway): Enable Gateway plugin build for 2026.1#6342
eliseong merged 1 commit intofeature/toolkitOnlyfrom
fixGateway

Conversation

@afida23
Copy link
Copy Markdown

@afida23 afida23 commented Apr 7, 2026

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Description

Gateway 2026.1's product-info.json contains moduleV2/productModuleV2 layout entries
without a classPath field. The intellij-plugin-structure library declares
ProductModuleV2.classPath as a non-null Kotlin parameter, so Jackson throws a
NullPointerException during deserialization, failing the build with "IDE is invalid".

This bug exists on the upstream master branch of
intellij-plugin-verifier
(ProductInfo.ktModuleV2 was fixed with a @JsonCreator factory, but
ProductModuleV2 was not), so no version of the library can be upgraded to as a fix.

Fix:

  • Added ProductInfoPatcher in buildSrc that patches cached product-info.json files,
    adding empty classPath: [] to layout entries missing it.
  • In toolkit-intellij-subplugin.gradle.kts, force-resolve the Gateway IDE dependency in
    afterEvaluate and run the patcher before bundledPlugins reads product-info.json.
    This makes the build work on first run with a clean Gradle cache.
  • Added xi:fallback to the module-core.xml xi:include in plugin-gateway.xml.
  • Removed 2026.1 from the Gateway skip list in settings.gradle.kts.

Tested this change and conformed that JetBrains Gateway 2026.1 is compatible for the CodeCatalyst provider.

Checklist

  • My code follows the code style of this project
  • I have added tests to cover my changes
  • A short description of the change has been added to the CHANGELOG if the change is customer-facing in the IDE.
  • I have added metrics for my changes (if required)

License

I confirm that my contribution is made under the terms of the Apache 2.0 license.

@afida23 afida23 requested a review from a team as a code owner April 7, 2026 18:20
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 7, 2026

Qodana for JVM

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

Copy link
Copy Markdown

@yuriivv yuriivv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@eliseong eliseong merged commit 4af1aa5 into feature/toolkitOnly Apr 7, 2026
20 of 22 checks passed
@eliseong eliseong deleted the fixGateway branch April 7, 2026 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants