Fix logs --since for non-follow mode#2170
Merged
Merged
Conversation
Honors --since when running chalice logs without --follow by passing startTime through the CloudWatch log paginator, and adds a regression test plus jmeslog entry.
ubaskota
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2144
Overview
This PR fixes
chalice logs --sincewhen running without--follow.Previously,
--sincewas parsed correctly but ignored by the non-follow log retrieval path, causingchalice logs --since ...to return older CloudWatch log events. The follow path worked because it already passedstartTimeto CloudWatch.Summary
startTimethrough theiter_log_events()CloudWatch paginator call.startTimeis sent for non-follow log retrieval.Testing
python -m pytest tests/functional/test_awsclient.py -k log tests/unit/test_logs.pyBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.