Skip to content

[TensorFlow][Training][EC2] TensorFlow 2.18.0 Currency Release #4485

Merged
Yadan-Wei merged 38 commits intoaws:masterfrom
Yadan-Wei:tf-2.18-tr-ec2
Jan 22, 2025
Merged

[TensorFlow][Training][EC2] TensorFlow 2.18.0 Currency Release #4485
Yadan-Wei merged 38 commits intoaws:masterfrom
Yadan-Wei:tf-2.18-tr-ec2

Conversation

@Yadan-Wei
Copy link
Contributor

@Yadan-Wei Yadan-Wei commented Jan 9, 2025

GitHub Issue #, if available:

Note:

  • If merging this PR should also close the associated Issue, please also add that Issue # to the Linked Issues section on the right.

  • All PR's are checked weekly for staleness. This PR will be closed if not updated in 30 days.

Description

  • Ubuntu 22.04
  • TensorFlow 2.18.0
  • CUDA 12.5.1
  • EFA 1.37.0
  • OPEN MPI 4.1.7
  • OFI 1.13.2
  • CUDNN 9.3.0.75
  • NCCL 2.23.4

Tests run

  • 2ae13ac Passed all ec2 test for TF2.18
  • f47ea4f Passed ec2 test for TF2.16 built with keras 3.8.0.
  • Also tested testTensorFlow and testTensorBoard with previous build image with keras 3.4.1.

NOTE: By default, docker builds are disabled. In order to build your container, please update dlc_developer_config.toml and specify the framework to build in "build_frameworks"

  • I have run builds/tests on commit for my changes.
Confused on how to run tests? Try using the helper utility...

Assuming your remote is called origin (you can find out more with git remote -v)...

  • Run default builds and tests for a particular buildspec - also commits and pushes changes to remote; Example:

python src/prepare_dlc_dev_environment.py -b </path/to/buildspec.yml> -cp origin

  • Enable specific tests for a buildspec or set of buildspecs - also commits and pushes changes to remote; Example:

python src/prepare_dlc_dev_environment.py -b </path/to/buildspec.yml> -t sanity_tests -cp origin

  • Restore TOML file when ready to merge

python src/prepare_dlc_dev_environment.py -rcp origin

NOTE: If you are creating a PR for a new framework version, please ensure success of the standard, rc, and efa sagemaker remote tests by updating the dlc_developer_config.toml file:

Expand
  • sagemaker_remote_tests = true
  • sagemaker_efa_tests = true
  • sagemaker_rc_tests = true

Additionally, please run the sagemaker local tests in at least one revision:

  • sagemaker_local_tests = true

Formatting

DLC image/dockerfile

Builds to Execute

Expand

Fill out the template and click the checkbox of the builds you'd like to execute

Note: Replace with <X.Y> with the major.minor framework version (i.e. 2.2) you would like to start.

  • build_pytorch_training_<X.Y>_sm

  • build_pytorch_training_<X.Y>_ec2

  • build_pytorch_inference_<X.Y>_sm

  • build_pytorch_inference_<X.Y>_ec2

  • build_pytorch_inference_<X.Y>_graviton

  • build_tensorflow_training_<X.Y>_sm

  • build_tensorflow_training_<X.Y>_ec2

  • build_tensorflow_inference_<X.Y>_sm

  • build_tensorflow_inference_<X.Y>_ec2

  • build_tensorflow_inference_<X.Y>_graviton

Additional context

PR Checklist

Expand
  • I've prepended PR tag with frameworks/job this applies to : [mxnet, tensorflow, pytorch] | [ei/neuron/graviton] | [build] | [test] | [benchmark] | [ec2, ecs, eks, sagemaker]
  • If the PR changes affects SM test, I've modified dlc_developer_config.toml in my PR branch by setting sagemaker_tests = true and efa_tests = true
  • If this PR changes existing code, the change fully backward compatible with pre-existing code. (Non backward-compatible changes need special approval.)
  • (If applicable) I've documented below the DLC image/dockerfile this relates to
  • (If applicable) I've documented below the tests I've run on the DLC image
  • (If applicable) I've reviewed the licenses of updated and new binaries and their dependencies to make sure all licenses are on the Apache Software Foundation Third Party License Policy Category A or Category B license list. See https://www.apache.org/legal/resolved.html.
  • (If applicable) I've scanned the updated and new binaries to make sure they do not have vulnerabilities associated with them.

NEURON/GRAVITON Testing Checklist

  • When creating a PR:
  • I've modified dlc_developer_config.toml in my PR branch by setting neuron_mode = true or graviton_mode = true

Benchmark Testing Checklist

  • When creating a PR:
  • I've modified dlc_developer_config.toml in my PR branch by setting ec2_benchmark_tests = true or sagemaker_benchmark_tests = true

Pytest Marker Checklist

Expand
  • (If applicable) I have added the marker @pytest.mark.model("<model-type>") to the new tests which I have added, to specify the Deep Learning model that is used in the test (use "N/A" if the test doesn't use a model)
  • (If applicable) I have added the marker @pytest.mark.integration("<feature-being-tested>") to the new tests which I have added, to specify the feature that will be tested
  • (If applicable) I have added the marker @pytest.mark.multinode(<integer-num-nodes>) to the new tests which I have added, to specify the number of nodes used on a multi-node test
  • (If applicable) I have added the marker @pytest.mark.processor(<"cpu"/"gpu"/"eia"/"neuron">) to the new tests which I have added, if a test is specifically applicable to only one processor type

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@Yadan-Wei Yadan-Wei requested a review from a team as a code owner January 9, 2025 22:32
@aws-deep-learning-containers-ci aws-deep-learning-containers-ci bot added build Reflects file change in build folder Size:S Determines the size of the PR tensorflow labels Jan 9, 2025
@aws-deep-learning-containers-ci aws-deep-learning-containers-ci bot added ec2 test Reflects file change in test folder labels Jan 13, 2025
@Yadan-Wei Yadan-Wei merged commit fb5628a into aws:master Jan 22, 2025
31 checks passed
@Yadan-Wei Yadan-Wei deleted the tf-2.18-tr-ec2 branch January 22, 2025 19:36
sirutBuasai pushed a commit to sirutBuasai/deep-learning-containers that referenced this pull request Feb 8, 2025
)

* add tf 2.18 x86 file

* add gpu docker file

* remove libssl1.1

* remove libssl1.1 in cpu

* use 4.1.6 for openmpi

* change ompi version and libssl2 version

* drop libreadline-gplv2-dev

* update gpu binary link

* update  tf-models-official version

* change BUILD NAME

* change TF_URL location

* change TF_URL location

* change profiler log directory for tf2.18

* change profiler log directory for tf2.18 bug fix

* not build

* change toml

* change tensorboard profile log diectory as well

* fix testTensorFlow log directory

* add allowlist and skip tf2.18 S3 test

* fix testTensorFlow and test TensorBoard script

* add start=True for dispatchServer and workerServer

* add start=True for start_dataservice

* run all tests and skip data service for tf2.18

* format

* fix dataservice test with limit data size and add back dataservice tests

* run regression test on TF2.16

* run regression test on TF2.16 with autopatch

* rebuild tf2.16

* make change to testTensorFlow and testTensorBoard to adopt keras 3.8.0 change

* do not build

* check /logs exist first

* revert toml

* revert toml

* fix typo

---------

Co-authored-by: Yadan Wei <yadanwei@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Reflects file change in build folder Size:S Determines the size of the PR test Reflects file change in test folder

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants