[PyTorch][Inference][EC2][SageMaker] Pytorch 2.6.0 Currency Release#4535
Merged
Yadan-Wei merged 37 commits intoaws:masterfrom Feb 11, 2025
Merged
[PyTorch][Inference][EC2][SageMaker] Pytorch 2.6.0 Currency Release#4535Yadan-Wei merged 37 commits intoaws:masterfrom
Yadan-Wei merged 37 commits intoaws:masterfrom
Conversation
added 20 commits
February 5, 2025 14:31
sirutBuasai
reviewed
Feb 10, 2025
Member
sirutBuasai
left a comment
There was a problem hiding this comment.
You'll need to edit this skip_dict (
) to run torchdata tests.
sirutBuasai
reviewed
Feb 11, 2025
| if [[ $(version $TORCHDATA_RELEASE_TAG) -ge $(version "0.10.0") ]] | ||
| then | ||
| TORCHDATA_TEST_SCRIPT="data/test/smoke_test/smoke_test.py" | ||
| python $TORCHDATA_TEST_SCRIPT |
Member
There was a problem hiding this comment.
we should run pytest instead of python so that we can get the summary info as usual
Contributor
Author
There was a problem hiding this comment.
Since the smoke_test only have two import, pytest cannot collect any tests and return a code not 0.
sirutBuasai
reviewed
Feb 11, 2025
|
|
||
| # torch data delete remote DataPipes and DataLoader2 from 0.10.0, | ||
| # so test_remote_io.py is deleted https://github.com/pytorch/data/pull/1332 | ||
| if [[ $(version $TORCHDATA_RELEASE_TAG) -ge $(version "0.10.0") ]] |
Member
There was a problem hiding this comment.
this if statement can be simplified to
if [ version check ]; then
SCRIPT="new_test"
else
SCRIPT="old_test"
fi
pytest $SCRIPT
Contributor
Author
There was a problem hiding this comment.
See above comments
sirutBuasai
approved these changes
Feb 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub Issue #, if available:
Note:
If merging this PR should also close the associated Issue, please also add that Issue # to the Linked Issues section on the right.
All PR's are checked weekly for staleness. This PR will be closed if not updated in 30 days.
Description
Tests run
NOTE: By default, docker builds are disabled. In order to build your container, please update dlc_developer_config.toml and specify the framework to build in "build_frameworks"
Confused on how to run tests? Try using the helper utility...
Assuming your remote is called
origin(you can find out more withgit remote -v)...python src/prepare_dlc_dev_environment.py -b </path/to/buildspec.yml> -cp originpython src/prepare_dlc_dev_environment.py -b </path/to/buildspec.yml> -t sanity_tests -cp originpython src/prepare_dlc_dev_environment.py -rcp originNOTE: If you are creating a PR for a new framework version, please ensure success of the standard, rc, and efa sagemaker remote tests by updating the dlc_developer_config.toml file:
Expand
sagemaker_remote_tests = truesagemaker_efa_tests = truesagemaker_rc_tests = trueAdditionally, please run the sagemaker local tests in at least one revision:
sagemaker_local_tests = trueFormatting
black -l 100on my code (formatting tool: https://black.readthedocs.io/en/stable/getting_started.html)DLC image/dockerfile
Builds to Execute
Expand
Fill out the template and click the checkbox of the builds you'd like to execute
Note: Replace with <X.Y> with the major.minor framework version (i.e. 2.2) you would like to start.
build_pytorch_training_<X.Y>_sm
build_pytorch_training_<X.Y>_ec2
build_pytorch_inference_<X.Y>_sm
build_pytorch_inference_<X.Y>_ec2
build_pytorch_inference_<X.Y>_graviton
build_tensorflow_training_<X.Y>_sm
build_tensorflow_training_<X.Y>_ec2
build_tensorflow_inference_<X.Y>_sm
build_tensorflow_inference_<X.Y>_ec2
build_tensorflow_inference_<X.Y>_graviton
Additional context
PR Checklist
Expand
NEURON/GRAVITON Testing Checklist
dlc_developer_config.tomlin my PR branch by settingneuron_mode = trueorgraviton_mode = trueBenchmark Testing Checklist
dlc_developer_config.tomlin my PR branch by settingec2_benchmark_tests = trueorsagemaker_benchmark_tests = truePytest Marker Checklist
Expand
@pytest.mark.model("<model-type>")to the new tests which I have added, to specify the Deep Learning model that is used in the test (use"N/A"if the test doesn't use a model)@pytest.mark.integration("<feature-being-tested>")to the new tests which I have added, to specify the feature that will be tested@pytest.mark.multinode(<integer-num-nodes>)to the new tests which I have added, to specify the number of nodes used on a multi-node test@pytest.mark.processor(<"cpu"/"gpu"/"eia"/"neuron">)to the new tests which I have added, if a test is specifically applicable to only one processor typeBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.