Skip to content

test python upgrade to 3.12#5294

Closed
Jyothirmaikottu wants to merge 49 commits intoaws:masterfrom
Jyothirmaikottu:test-pythonUpgrade
Closed

test python upgrade to 3.12#5294
Jyothirmaikottu wants to merge 49 commits intoaws:masterfrom
Jyothirmaikottu:test-pythonUpgrade

Conversation

@Jyothirmaikottu
Copy link

GitHub Issue #, if available:

Note:

  • If merging this PR should also close the associated Issue, please also add that Issue # to the Linked Issues section on the right.

  • All PR's are checked weekly for staleness. This PR will be closed if not updated in 30 days.

Description

Tests Run

By default, docker image builds and tests are disabled. Two ways to run builds and tests:

  1. Using dlc_developer_config.toml
  2. Using this PR description (currently only supported for PyTorch, TensorFlow, vllm, and base images)
How to use the helper utility for updating dlc_developer_config.toml

Assuming your remote is called origin (you can find out more with git remote -v)...

  • Run default builds and tests for a particular buildspec - also commits and pushes changes to remote; Example:

python src/prepare_dlc_dev_environment.py -b </path/to/buildspec.yml> -cp origin

  • Enable specific tests for a buildspec or set of buildspecs - also commits and pushes changes to remote; Example:

python src/prepare_dlc_dev_environment.py -b </path/to/buildspec.yml> -t sanity_tests -cp origin

  • Restore TOML file when ready to merge

python src/prepare_dlc_dev_environment.py -rcp origin

NOTE: If you are creating a PR for a new framework version, please ensure success of the local, standard, rc, and efa sagemaker tests by updating the dlc_developer_config.toml file:

  • sagemaker_remote_tests = true
  • sagemaker_efa_tests = true
  • sagemaker_rc_tests = true
  • sagemaker_local_tests = true
How to use PR description Use the code block below to uncomment commands and run the PR CodeBuild jobs. There are two commands available:
  • # /buildspec <buildspec_path>
    • e.g.: # /buildspec pytorch/training/buildspec.yml
    • If this line is commented out, dlc_developer_config.toml will be used.
  • # /tests <test_list>
    • e.g.: # /tests sanity security ec2
    • If this line is commented out, it will run the default set of tests (same as the defaults in dlc_developer_config.toml): sanity, security, ec2, ecs, eks, sagemaker, sagemaker-local.
# /buildspec <buildspec_path>
# /tests <test_list>

Formatting

PR Checklist

Expand
  • I've prepended PR tag with frameworks/job this applies to : [mxnet, tensorflow, pytorch] | [ei/neuron/graviton] | [build] | [test] | [benchmark] | [ec2, ecs, eks, sagemaker]
  • If the PR changes affects SM test, I've modified dlc_developer_config.toml in my PR branch by setting sagemaker_tests = true and efa_tests = true
  • If this PR changes existing code, the change fully backward compatible with pre-existing code. (Non backward-compatible changes need special approval.)
  • (If applicable) I've documented below the DLC image/dockerfile this relates to
  • (If applicable) I've documented below the tests I've run on the DLC image
  • (If applicable) I've reviewed the licenses of updated and new binaries and their dependencies to make sure all licenses are on the Apache Software Foundation Third Party License Policy Category A or Category B license list. See https://www.apache.org/legal/resolved.html.
  • (If applicable) I've scanned the updated and new binaries to make sure they do not have vulnerabilities associated with them.

Pytest Marker Checklist

Expand
  • (If applicable) I have added the marker @pytest.mark.model("<model-type>") to the new tests which I have added, to specify the Deep Learning model that is used in the test (use "N/A" if the test doesn't use a model)
  • (If applicable) I have added the marker @pytest.mark.integration("<feature-being-tested>") to the new tests which I have added, to specify the feature that will be tested
  • (If applicable) I have added the marker @pytest.mark.multinode(<integer-num-nodes>) to the new tests which I have added, to specify the number of nodes used on a multi-node test
  • (If applicable) I have added the marker @pytest.mark.processor(<"cpu"/"gpu"/"eia"/"neuron">) to the new tests which I have added, if a test is specifically applicable to only one processor type

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@Jyothirmaikottu Jyothirmaikottu requested a review from a team as a code owner September 23, 2025 17:39
@aws-deep-learning-containers-ci aws-deep-learning-containers-ci bot added authorized Size:XS Determines the size of the PR labels Sep 23, 2025
@aws-deep-learning-containers-ci aws-deep-learning-containers-ci bot added the Size:S Determines the size of the PR label Sep 23, 2025
@aws-deep-learning-containers-ci aws-deep-learning-containers-ci bot added benchmark test Reflects file change in test folder labels Sep 24, 2025
@aws-deep-learning-containers-ci aws-deep-learning-containers-ci bot added the build Reflects file change in build folder label Sep 29, 2025
j-w-l and others added 20 commits September 29, 2025 16:38
…euronx (aws#5278)

* Update ['dlc_developer_config.toml']

dlc_developer_config.toml:
{   'build': {   'build_frameworks': ['huggingface_pytorch'],
                 'build_inference': False,
                 'build_training': True},
    'buildspec_override': {   'dlc-pr-huggingface-pytorch-neuronx-training': 'huggingface/pytorch/training/buildspec-neuronx.yml'},
    'dev': {   'arm64_mode': False,
               'deep_canary_mode': False,
               'graviton_mode': False,
               'neuronx_mode': True},
    'test': {   'ec2_tests': False,
                'ecs_tests': False,
                'eks_tests': False,
                'sagemaker_local_tests': False,
                'sagemaker_remote_tests': False,
                'sanity_tests': True,
                'security_tests': False}}

* patch: linux-libc-dev vulnerability in huggingface-pytorch-training-neuronx:2.1.2-transformers4.48.1-neuronx-py310-sdk2.20.0-ubuntu20.04

* Restore ['dlc_developer_config.toml']

dlc_developer_config.toml:
('Restore to '
 'https://raw.githubusercontent.com/aws/deep-learning-containers/master/dlc_developer_config.toml')

---------

Co-authored-by: Jonathan Lee <jonwlee@amazon.com>
Co-authored-by: varunmoris <176621270+varunmoris@users.noreply.github.com>
* update 0.10.2

* update 0.10.2
* changelog update

* update changelog to 0.10.2
* Add Neuronx SDK 2.26.0 images to release_images.md

* Remove transformers
* rebuild pytorch sm arm64 2.6 image

* revert toml

* Rebuild pt 2.5

* Rebuild pt 2.6

* rebuild and test pt2.5

* rebuild and test pt2.5 arm64 ec2

* rebuild and test pt2.5 arm64 ec2

* test --cache error

* test --cache error

* fix --cache problem

* fix --cache problem

* fix --cache problem

* revert toml and dlc py scans

* remove py scan files
* patch tf training 2.18 ec2

* patch tf training 2.18 sm

* autopatch tf 2.18 sm

* autopatch tf 2.18 sm

* add docker login

* add docker login

* retest tensorflow 2.18

* build tf 2.18

* build tf2.18

* revert toml
* patch pytorch 2.5 inference ARM64 sagemaker image
* test tf 2.18 inference amr64 sm

* test tf 2.18 inference amr64 ec2

* test tf 2.18 inference amr64 sm

* revert toml
* Patch tensoflow 2.19 inference and training images
* fix: update neuronx huggingface tests

* black formatter

* Add inference_ami_version=al2-ami-sagemaker-inference-neuron-2 to all neuronx tests

---------

Co-authored-by: Sirut Buasai <73297481+sirutBuasai@users.noreply.github.com>
* Allowlisting for PyTorch 2.6 inference ARM image
@Jyothirmaikottu Jyothirmaikottu requested review from a team as code owners September 29, 2025 23:38
@aws-deep-learning-containers-ci aws-deep-learning-containers-ci bot added huggingface Reflects file change in huggingface folder Size:XL Determines the size of the PR labels Sep 29, 2025
@Jyothirmaikottu Jyothirmaikottu deleted the test-pythonUpgrade branch September 29, 2025 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

authorized build Reflects file change in build folder huggingface Reflects file change in huggingface folder pytorch Reflects file change in pytorch folder Size:S Determines the size of the PR Size:XL Determines the size of the PR Size:XS Determines the size of the PR test Reflects file change in test folder

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants