Skip to content

chore(huggingface-vllm): re-enable PR workflow; add transformers_version to release spec; rename framework#6287

Merged
sallyseok merged 6 commits into
mainfrom
sallyseo-hf-release
Jun 25, 2026
Merged

chore(huggingface-vllm): re-enable PR workflow; add transformers_version to release spec; rename framework#6287
sallyseok merged 6 commits into
mainfrom
sallyseo-hf-release

Conversation

@sallyseok

Copy link
Copy Markdown
Contributor

Purpose

  • transformers_version needs to be emitted to the release workflow in order for it to handle tag generation.
  • Renamed the framework name from huggingface_vllm with underscore to huggingface-vllm with hyphen in order to match the ECR repository name and eliminate unnecessary discrepancies. The other framework name variables that use underscores (like vllm_server) do not have corresponding ECR repository names associated with it (repository is just vllm).
  • Also setting release to "gamma" to test before actual release

Test Plan

Test Result


Toggle if you are merging into master Branch

By default, docker image builds and tests are disabled. Two ways to run builds and tests:

  1. Using dlc_developer_config.toml
  2. Using this PR description (currently only supported for PyTorch, TensorFlow, vllm, and base images)
How to use the helper utility for updating dlc_developer_config.toml

Assuming your remote is called origin (you can find out more with git remote -v)...

  • Run default builds and tests for a particular buildspec - also commits and pushes changes to remote; Example:

python src/prepare_dlc_dev_environment.py -b </path/to/buildspec.yml> -cp origin

  • Enable specific tests for a buildspec or set of buildspecs - also commits and pushes changes to remote; Example:

python src/prepare_dlc_dev_environment.py -b </path/to/buildspec.yml> -t sanity_tests -cp origin

  • Restore TOML file when ready to merge

python src/prepare_dlc_dev_environment.py -rcp origin

NOTE: If you are creating a PR for a new framework version, please ensure success of the local, standard, rc, and efa sagemaker tests by updating the dlc_developer_config.toml file:

  • sagemaker_remote_tests = true
  • sagemaker_efa_tests = true
  • sagemaker_rc_tests = true
  • sagemaker_local_tests = true
How to use PR description Use the code block below to uncomment commands and run the PR CodeBuild jobs. There are two commands available:
  • # /buildspec <buildspec_path>
    • e.g.: # /buildspec pytorch/training/buildspec.yml
    • If this line is commented out, dlc_developer_config.toml will be used.
  • # /tests <test_list>
    • e.g.: # /tests sanity security ec2
    • If this line is commented out, it will run the default set of tests (same as the defaults in dlc_developer_config.toml): sanity, security, ec2, ecs, eks, sagemaker, sagemaker-local.
# /buildspec <buildspec_path>
# /tests <test_list>
Toggle if you are merging into main Branch

PR Checklist

  • [] I ran pre-commit run --all-files locally before creating this PR. (Read DEVELOPMENT.md for details).

Signed-off-by: Sally Seok <sallyseo@amazon.com>

metadata:
framework: "huggingface_vllm"
framework: "huggingface-vllm"

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the convention is to use _ instead of - for frameworks now. Any reason why we want - for huggingface?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renamed the framework name from huggingface_vllm with underscore to huggingface-vllm with hyphen in order to match the ECR repository name and eliminate unnecessary discrepancies. The other framework name variables that use underscores (like vllm_server) do not have corresponding ECR repository names associated with it (repository is just vllm).

sirutBuasai
sirutBuasai previously approved these changes Jun 25, 2026
Signed-off-by: Sally Seok <sallyseo@amazon.com>
Signed-off-by: Sally Seok <sallyseo@amazon.com>
Signed-off-by: Sally Seok <sallyseo@amazon.com>
@sallyseok sallyseok changed the title Add transformers_version to release spec; rename huggingface-vllm chore(huggingface-vllm): re-enable PR workflow; add transformers_version to release spec; rename framework Jun 25, 2026
Signed-off-by: Sally Seok <sallyseo@amazon.com>
Signed-off-by: Sally Seok <sallyseo@amazon.com>
@sallyseok sallyseok enabled auto-merge (squash) June 25, 2026 23:37
@sallyseok sallyseok merged commit 1833626 into main Jun 25, 2026
139 of 141 checks passed
@sirutBuasai sirutBuasai deleted the sallyseo-hf-release branch June 25, 2026 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants