feat(vllm-omni): accept application/json on video routes#6298
Merged
Conversation
Jyothirmaikottu
force-pushed
the
jkottu/omni-sagemaker-json-content-type
branch
4 times, most recently
from
520997f to
748f15f
Compare
Jyothirmaikottu
changed the title
Jyothirmaikottu
force-pushed
the
jkottu/omni-sagemaker-json-content-type
branch
from
017965a to
b8de4ca
Compare
Restore JSON->multipart conversion in the SageMaker routing middleware for the form-data video routes (/v1/videos, /v1/videos/sync). These upstream handlers only accept multipart/form-data, so a SageMaker caller sending application/json with route=/v1/videos/sync got a 400. The middleware now converts a JSON object body into multipart/form-data when the resolved route is one of FORM_DATA_ROUTES, so JSON callers work without changing the proven multipart path (byte-for-byte passthrough). Stays on vllm-omni 0.21.0rc1 (no framework bump): the 0.22.0 release ships a TrackingArgumentParser that crashes on argparse append actions (our --middleware flag), so the version bump is deferred until the upstream fix is released. Bumps dlc_minor_version 3 -> 4 for the middleware change.
Jyothirmaikottu
force-pushed
the
jkottu/omni-sagemaker-json-content-type
branch
from
b8de4ca to
fe81d8c
Compare
Jyothirmaikottu
commented
Jul 1, 2026
| uv venv --python 3.12 | ||
| source .venv/bin/activate | ||
| uv pip install pyyaml | ||
| python3 scripts/ci/parse_model_config.py --config .github/config/model-tests/vllm-omni-model-tests.yml --runner-type codebuild-fleet |
Contributor
Author
There was a problem hiding this comment.
multipart test is not needed on ec2 so we can add this flag to control that
Jyothirmaikottu
commented
Jul 1, 2026
|
|
||
| # Regression Test # 7min | ||
| cd vllm_source/tests | ||
| uv pip install $UV_FLAGS modelscope |
Contributor
Author
There was a problem hiding this comment.
upstream vllm regression which also blocks our release.
Yadan-Wei
approved these changes
Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restores JSON->multipart conversion in the SageMaker routing middleware for the form-data video routes (
/v1/videos,/v1/videos/sync), so callers can sendapplication/jsoninstead of multipart. The proven multipart path is unchanged (byte-for-byte passthrough).Stays on vllm-omni 0.21.0rc1 — no framework bump. Bumps
dlc_minor_version3 -> 4.