Skip to content

tensorflow: 2.21 legacy tags + gamma flip#6363

Merged
bhanutejagk merged 2 commits into
mainfrom
tensorflow-2.21-legacy-tags
Jul 8, 2026
Merged

tensorflow: 2.21 legacy tags + gamma flip#6363
bhanutejagk merged 2 commits into
mainfrom
tensorflow-2.21-legacy-tags

Conversation

@bhanutejagk

@bhanutejagk bhanutejagk commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Changes

Two commits, per-file:

Commit 1 (4a274103) — align configs with legacy tag shape

  • Drop platform: "sagemaker" metadata field. Legacy templates use {cx_suffix} from customer_type; platform becomes dead metadata.
  • Update prod_image to match the actual legacy tag that will be pushed:
    • CUDA: tensorflow-training:2.21-gpu-py312-cu129-amzn2023-sagemaker-v1
    • CPU: tensorflow-training:2.21-cpu-py312-amzn2023-sagemaker-v1
      Used by .github/actions/resolve-image-uri as fallback in test-only runs.

Commit 2 — flip release configs to gamma

  • release: false → true
  • private_registry: false → true
  • environment: "production" → "gamma"

Expected gamma tags (per legacy shape)

cuda config produces:

  • 2.21.0-gpu-py312-cu129-amzn2023-sagemaker
  • 2.21.0-gpu-py312-cu129-amzn2023-sagemaker-v1.0
  • 2.21.0-gpu-py312-cu129-amzn2023-sagemaker-v1.0-YYYY-MM-DD-HH-MM-SS
  • 2.21-gpu-py312-cu129-amzn2023-sagemaker
  • 2.21-gpu-py312-cu129-amzn2023-sagemaker-v1
  • 2.21-gpu-py312 (sagemaker_short_tag)
  • 2.21.0-gpu-py312 (sagemaker_long_tag)

cpu config produces the same shape with -cpu- replacing -gpu-py312-cu129-.

Drops the `platform: "sagemaker"` metadata field and updates
`prod_image` to match the legacy tag shape.

Pairs with the DLContainersReleaseLogicPython change reverting the
tensorflow entry in frameworks.yml from new-format
(release_tag / short_release_tag with {platform_suffix}) back to
legacy PyTorch shape (base_dlc_tag / full_dlc_tag with {cx_suffix}).

- platform: legacy templates ignore it and use {cx_suffix} derived
  from customer_type instead. Drop to avoid dead metadata.
- prod_image: was still on the new-format shape
  (tensorflow:2.21-cu129-amzn2023-sagemaker). Update to the legacy
  shape that will actually be pushed:
    tensorflow-training:2.21-gpu-py312-cu129-amzn2023-sagemaker-v1
    tensorflow-training:2.21-cpu-py312-amzn2023-sagemaker-v1
  Used by resolve-image-uri as fallback in test-only runs.

Release configs stay `release: false` — the gamma flip is a follow-up
PR after the release-logic change lands and gamma ECR repos exist.
Enables autorelease pushes to the DLC gamma ECR (account
028651357192) for validation before flipping to production.

Changes per config (both cpu + cuda):
- release: false → true (allow the release-gate job to fire)
- private_registry: false → true (push to private registry only)
- environment: "production" → "gamma"
- force_release stays false (respect blocked-day / hours checks)
- public_registry stays false (gamma-only, no public gallery)
- enable_soci stays false (skip SOCI on gamma; enable for prod later)

Prerequisites before this can succeed:
1. DLContainersReleaseLogicPython CR-287814183 must merge (reverts
   the tensorflow entry in frameworks.yml to legacy shape).
2. Gamma account 028651357192 must have `tensorflow-training` and
   `tensorflow-inference` ECR repos created.
@bhanutejagk bhanutejagk changed the title tensorflow: align 2.21 configs with legacy tag format tensorflow: 2.21 legacy tags + gamma flip Jul 8, 2026
@bhanutejagk bhanutejagk marked this pull request as ready for review July 8, 2026 22:22
@bhanutejagk bhanutejagk merged commit cde42fc into main Jul 8, 2026
47 of 48 checks passed
@sirutBuasai sirutBuasai deleted the tensorflow-2.21-legacy-tags branch July 9, 2026 19:30
bhanutejagk pushed a commit that referenced this pull request Jul 9, 2026
Promotes TF 2.21 SageMaker configs from gamma to production release
after gamma validation. Autorelease will push to the prod ECR
(061416347176) and sync to public.ecr.aws.

Changes per config (both cpu + cuda):
- public_registry: false -> true (publish to public gallery)
- enable_soci: false -> true (SOCI indexing enabled for prod)
- environment: "gamma" -> "production"

Prerequisites before merge:
1. PR #6363 (legacy tags + gamma flip) must have merged to main.
2. At least one clean gamma autorelease cycle must have completed
   with expected tag shapes verified in the gamma ECR
   (028651357192.dkr.ecr.<region>.amazonaws.com/tensorflow-training).
3. Optional: gamma image smoke-tested (docker pull + TF import,
   or SageMaker training job against the gamma image URI).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants