Skip to content

Conversation

@panktishah26
Copy link
Member

@panktishah26 panktishah26 commented Nov 4, 2025

Description of changes:
For tinkerbell, we are seeing e2e tests failures with the error message like below,

cluster condition ControlPlaneReady is False: Control plane Node eksa-cp07 does not have a corresponding Machine

this happens when capt takes more than 10s (default node deletion timeout) to delete the machine corresponding to node.

Increasing nodedeletiontimeout to 30s for tinkerbell provider to overcome this issue.

Testing (if applicable):

Documentation added/planned (if applicable):

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from panktishah26. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eks-distro-bot eks-distro-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 4, 2025
@panktishah26 panktishah26 force-pushed the tinkerbell-node-delete-infinite branch from 2b4c04c to 5ef1768 Compare November 5, 2025 05:18
@panktishah26 panktishah26 force-pushed the tinkerbell-node-delete-infinite branch from 5ef1768 to 3ece945 Compare November 10, 2025 23:43
@panktishah26 panktishah26 changed the title Update nodedeletiontimeout for tinkerbell to infinite Update nodedeletiontimeout for tinkerbell to 30s Nov 10, 2025
@codecov
Copy link

codecov bot commented Nov 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.01%. Comparing base (2b32936) to head (3ece945).
⚠️ Report is 25 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10283      +/-   ##
==========================================
- Coverage   70.01%   70.01%   -0.01%     
==========================================
  Files         680      680              
  Lines       41748    41751       +3     
==========================================
+ Hits        29230    29231       +1     
- Misses      10721    10723       +2     
  Partials     1797     1797              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@panktishah26
Copy link
Member Author

/test eks-anywhere-presubmit

@panktishah26
Copy link
Member Author

/test eks-anywhere-e2e-presubmit

@eks-distro-bot
Copy link
Collaborator

@panktishah26: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
eks-anywhere-e2e-presubmit 3ece945 link true /test eks-anywhere-e2e-presubmit

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants