Revert 10344 and 10345 #10346
Closed
Revert 10344 and 10345 #10346
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add second NIC and validation * Update pkg/api/v1alpha1/vspheremachineconfig_types.go Co-authored-by: Subbarao Vakati <[email protected]> * add template unit test for networks field * add period at the end of comment to solve linting issue --------- Co-authored-by: Amelia Lu <[email protected]> Co-authored-by: Subbarao Vakati <[email protected]>
…#10238) Co-authored-by: rajeshvenkata <[email protected]>
…0243) Co-authored-by: Shizhao Liu <[email protected]>
Co-authored-by: Shizhao Liu <[email protected]>
Co-authored-by: rajeshvenkata <[email protected]>
Co-authored-by: Shizhao Liu <[email protected]>
Assumes roles on-demand before each test that needs credentials as aws role chaning only allows maximum of 1 hour and e2e test suites take longer than that Co-authored-by: Subbu Vakati <[email protected]>
Co-authored-by: Subbu Vakati <[email protected]>
…0253) Co-authored-by: Subbu Vakati <[email protected]>
aws#10257) Co-authored-by: panktishah26 <[email protected]>
Co-authored-by: rajeshvenkata <[email protected]>
Co-authored-by: panktishah26 <[email protected]>
Co-authored-by: Shizhao Liu <[email protected]>
Remove the temporary restriction that prevented users from changing cilium.skipUpgrade from true to false. This enables transitioning from self-managed Cilium back to EKS-A managed Cilium. - Remove validation from cluster webhook (controller) - Remove validation from upgrade validations (CLI) - Update tests to allow skipUpgrade toggle in both directions Co-authored-by: Murat Parlakisik <[email protected]>
aws#10237) Remove the temporary restriction that prevented users from changing cilium.skipUpgrade from true to false. This enables transitioning from self-managed Cilium back to EKS-A managed Cilium. - Remove validation from cluster webhook (controller) - Remove validation from upgrade validations (CLI) - Update tests to allow skipUpgrade toggle in both directions
Co-authored-by: panktishah26 <[email protected]>
Co-authored-by: panktishah26 <[email protected]>
* add e2e for second nic * add helper function for networks e2e * add e2e test simple flow for second network interface configuration * replace hardcoded network to retrieve from secret manager * change worker node name to constant --------- Co-authored-by: Amelia Lu <[email protected]>
Co-authored-by: panktishah26 <[email protected]>
Co-authored-by: panktishah26 <[email protected]>
…#10274) Co-authored-by: Subbu Vakati <[email protected]>
…luster (aws#10279) Co-authored-by: Saurabh Parekh <[email protected]>
…ws#10285) Co-authored-by: rajeshvenkata <[email protected]>
…aws#10286) * Add network validation for e2e test for second nic * add test * Set timeout for getting IP * use machines.c to judge IP * filter out non workernode * make the variable dynamic * revert the change * Fail the test to make sure the test run * filter out etcd * solve linting issue --------- Co-authored-by: Amelia Lu <[email protected]>
Co-authored-by: rajeshvenkata <[email protected]>
…rameters (aws#10293) Add comprehensive documentation for the new helmValues field in Cilium CNI configuration, which provides full flexibility to configure any Cilium Helm chart parameter directly. Changes: - Add new "Helm Values Configuration for Cilium plugin" section with detailed explanation and example showing multiple configuration options - Mark policyEnforcementMode as deprecated - Mark egressMasqueradeInterfaces as deprecated - Mark routingMode, ipv4NativeRoutingCIDR, and ipv6NativeRoutingCIDR as deprecated - Mark cniExclusive as deprecated - Mark skipUpgrade as deprecated - Add deprecation notices to all legacy parameter sections pointing users to helmValues configuration - Include example demonstrating helmValues usage with policy enforcement, egress masquerading, routing mode, CNI exclusive mode, and Hubble features When helmValues is specified, it takes precedence over all other Cilium-specific fields in the configuration. Co-authored-by: Murat Parlakisik <[email protected]>
Co-authored-by: Shizhao Liu <[email protected]>
…0296) * docs: add AWS-supported Cilium management guide Add comprehensive documentation for managing AWS-supported Cilium in EKS Anywhere clusters. This guide covers: - Overview of EKS-A managed vs self-managed Cilium approaches - Installing AWS-supported Cilium with Helm for self-management - Pros and cons of self-managing Cilium deployment - Migration path from open source to AWS-supported version - Transitioning from self-managed to EKS-A managed Cilium - Verification steps and expected outputs The documentation helps users understand their options for managing Cilium CNI and provides clear instructions for each approach. * Apply suggestions from code review Co-authored-by: Shizhao Liu <[email protected]> --------- Co-authored-by: Murat Parlakisik <[email protected]> Co-authored-by: Murat Parlakisik <[email protected]> Co-authored-by: Shizhao Liu <[email protected]>
Co-authored-by: rajeshvenkata <[email protected]>
Co-authored-by: panktishah26 <[email protected]>
Co-authored-by: panktishah26 <[email protected]>
Co-authored-by: panktishah26 <[email protected]>
Co-authored-by: panktishah26 <[email protected]>
Co-authored-by: panktishah26 <[email protected]>
Co-authored-by: Subbu Vakati <[email protected]>
Co-authored-by: Subbu Vakati <[email protected]>
Co-authored-by: panktishah26 <[email protected]>
Co-authored-by: Subbu Vakati <[email protected]>
Co-authored-by: panktishah26 <[email protected]>
Co-authored-by: panktishah26 <[email protected]>
Co-authored-by: panktishah26 <[email protected]>
Co-authored-by: panktishah26 <[email protected]>
…rated packages testing for the release (aws#10344)
This reverts commit a40ab36.
Collaborator
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
eks-distro-bot
added
the
size/XXL
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #10346 +/- ##
==========================================
+ Coverage 69.98% 70.00% +0.01%
==========================================
Files 681 680 -1
Lines 41814 41751 -63
==========================================
- Hits 29265 29229 -36
+ Misses 10757 10724 -33
- Partials 1792 1798 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
This PR reverts #10344 and #10345
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.