Skip to content

Conversation

@rajeshvenkata
Copy link
Member

@rajeshvenkata rajeshvenkata commented Dec 5, 2025

Issue #, if available:
https://github.com/aws/eks-anywhere-internal/issues/3731
Description of changes:
Set DHCP relay sourceInterface from LoadBalancerInterface config.

When LoadBalancerInterface is configured in TinkerbellDatacenterConfig, propagate the same interface to the DHCP relay's sourceInterface. This ensures the relay listens for DHCP broadcasts on the correct network interface where bare metal machines are located.

Previously only kube-vip used this interface setting, leaving the relay to auto-detect which could pick the wrong interface in multi-NIC setups.

Testing (if applicable):

Specified a dummy interface in loadbalancerinterface in TinkerbellDatacenterConfig and tried to create a cluster and verified that relay has the specified interface in the args

Screenshot 2025-12-05 at 4 03 21 PM Screenshot 2025-12-05 at 4 02 51 PM

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from rajeshvenkata. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eks-distro-bot eks-distro-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 5, 2025
@codecov
Copy link

codecov bot commented Dec 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.17%. Comparing base (a6f7473) to head (1078c7c).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10421   +/-   ##
=======================================
  Coverage   70.17%   70.17%           
=======================================
  Files         670      670           
  Lines       41643    41644    +1     
=======================================
+ Hits        29221    29222    +1     
  Misses      10620    10620           
  Partials     1802     1802           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants