Separate pbc packages#10797
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
eks-distro-bot
added
the
size/L
Codecov Report❌ Patch coverage is ❌ Your patch check has failed because the patch coverage (20.75%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #10797 +/- ##
==========================================
- Coverage 72.52% 72.45% -0.08%
==========================================
Files 608 608
Lines 39470 39520 +50
==========================================
+ Hits 28625 28633 +8
- Misses 9111 9150 +39
- Partials 1734 1737 +3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
/retest |
Run `make manifests` and `make update-bundle-golden-files` to add the crdChart field to the Bundles CRD schema and update related CRDs.
eks-distro-bot
added
size/XXL
The +kubebuilder:validation:Required markers on sub-fields of Image, Archive, and Manifest were not enforced by the old controller-gen but the newer version propagates them, causing validation failures for optional/empty nested objects (crdChart, cloudStack, bottlerocket, etc).
The +kubebuilder:validation:Required markers on EksDRelease fields (channel, kubeVersion, gitCommit, manifestUrl, name) were not enforced by the old controller-gen v0.8.0 but the newer version propagates them, causing validation failures in envtest and presubmit.
2 participants
Issue #, if available:
Description of changes:
Testing (if applicable):
Documentation added/planned (if applicable):
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.