feat(tinkerbell): increase node deletion timeout to 30s#10852
Open
howard-junec wants to merge 1 commit into
Open
feat(tinkerbell): increase node deletion timeout to 30s#10852howard-junec wants to merge 1 commit into
howard-junec wants to merge 1 commit into
Conversation
Increase the node deletion timeout for Tinkerbell CP and workers from the default 10s to 30s. The default 10s is too short to survive a brief API server blip during control plane scale-down (~45s observed), causing CAPI to give up on node deletion and leaving orphan nodes, which fails the ControlPlaneReady condition. Fresh implementation of the same intent as aws#10283 using the current CAPI v1beta2 API (deletion.nodeDeletionTimeoutSeconds: int32) instead of the old v1beta1 field (nodeDeletionTimeout: duration).
Collaborator
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
eks-distro-bot
added
the
size/M
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #10852 +/- ##
=======================================
Coverage 72.51% 72.52%
=======================================
Files 608 608
Lines 39470 39470
=======================================
+ Hits 28623 28625 +2
+ Misses 9112 9111 -1
+ Partials 1735 1734 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Increase node deletion timeout to 30s for Tinkerbell (v1beta2)
Description of changes:
Increase the node deletion timeout for Tinkerbell CP and workers from
the default 10s to 30s. The default 10s is too short to survive a brief
API server blip during control plane scale-down (~45s observed), causing
CAPI to give up on node deletion and leaving orphan nodes, which fails
the ControlPlaneReady condition.
Fresh implementation of the same intent as #10283 using the current
CAPI v1beta2 API (deletion.nodeDeletionTimeoutSeconds: int32) instead
of the old v1beta1 field (nodeDeletionTimeout: duration).
Issue #, if available:
Supersedes #10283
Testing (if applicable):
go test ./pkg/providers/tinkerbell/...)failures observed consistently in release-0.26 nightly runs
Documentation added/planned (if applicable):
N/A