Add revisionHistoryLimit support to aws-for-fluent-bit values#1124
Open
booleanbetrayal wants to merge 2 commits intoaws:masterfrom
Open
Add revisionHistoryLimit support to aws-for-fluent-bit values#1124booleanbetrayal wants to merge 2 commits intoaws:masterfrom
booleanbetrayal wants to merge 2 commits intoaws:masterfrom
Conversation
PettitWesley
previously approved these changes
Jun 19, 2024
PettitWesley
approved these changes
Jun 19, 2024
Author
|
Thanks for the review @PettitWesley ! |
Author
|
Just checking on what the merge criteria is now that this has been approved. Looking forward to de-cluttering! |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Lack of support for
revisionHistoryLimitinaws-for-fluent-bitchart values /DaemonSetleads to potentially unnecessary / annoying clutter of revision sets.Description of changes
Adds
revisionHistoryLimitsupport inaws-for-fluent-bitwith defaults set to K8s default, following the lead inaws-load-balancer-controller.Checklist
README.mdfor modified charts)versioninChart.yamlfor the modified chart(s)Testing
helm templatevalidation