Skip to content

Fixes update windows base image tag files in other repos #771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 12, 2023

Conversation

jaxesn
Copy link
Member

@jaxesn jaxesn commented Jan 12, 2023

Issue #, if available:

Description of changes:

We got our first windows base image update yesterday. The code used to update the tag files in other repos, like eks-distro, was only looking at the al2 block of #768. This fixes this to look at both al2 and windows.

Once this is merged, i am going to rerun https://prow.eks.amazonaws.com/view/s3/prowdataclusterstack-316434458-prowbucket7c73355c-1n9f9v93wpjcm/logs/eks-distro-base-tag-files-update-postsubmit/1613510023281905664 to ensure it properly opens the PR in eks-distro.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from jaxesn by writing /assign @jaxesn in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jaxesn jaxesn merged commit d3cf7ed into aws:main Jan 12, 2023
danbudris pushed a commit to danbudris/eks-distro-build-tooling that referenced this pull request Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants