Skip to content

Increase disk space when building Windows Container image#660

Merged
eks-distro-bot merged 1 commit intoaws:mainfrom
KlwntSingh:windows
May 15, 2025
Merged

Increase disk space when building Windows Container image#660
eks-distro-bot merged 1 commit intoaws:mainfrom
KlwntSingh:windows

Conversation

@KlwntSingh
Copy link
Copy Markdown
Contributor

@KlwntSingh KlwntSingh commented May 9, 2025

Issue #, if available:
Prow jobs are failing with no space left on device, refer prow job logs.. This error started after adding support to build WS2025 container image.

Description of changes:
This PR add support to building Windows Server 2025 container images. Unfortuntanely, prow jobs are failing with no space left on device, refer prow job logs. This increase is required to address this issue.

Testing
make verify-prowjobs succeeds.

make verify-prowjobs -C templater
go fmt ./...
go generate ./...
go vet ./...
go build -o ./bin/generate-prowjobs github.com/aws/eks-distro-prow-jobs/templater
./bin/generate-prowjobs
./scripts/verify-prowjobs.sh

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot
Copy link
Copy Markdown
Collaborator

Hi @KlwntSingh. Thanks for your PR.

I'm waiting for a aws member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This increase is required to address `no space left on device` issue after adding support to building Windows Server 2025 images.
@mahakagi
Copy link
Copy Markdown
Member

/ok-to-test

@mahakagi
Copy link
Copy Markdown
Member

/lgtm

@mahakagi
Copy link
Copy Markdown
Member

/approve

@eks-distro-bot
Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mahakagi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eks-distro-bot eks-distro-bot merged commit c26d1d5 into aws:main May 15, 2025
2 checks passed
@eks-distro-bot
Copy link
Copy Markdown
Collaborator

@KlwntSingh: Updated the job-config configmap in namespace default at cluster default using the following files:

  • key eks-distro-base-presubmits-windows.yaml using file jobs/aws/eks-distro-build-tooling/eks-distro-base-presubmits-windows.yaml
Details

In response to this:

Issue #, if available:
Prow jobs are failing with no space left on device, refer prow job logs.. This error started after adding support to build WS2025 container image.

Description of changes:
This PR add support to building Windows Server 2025 container images. Unfortuntanely, prow jobs are failing with no space left on device, refer prow job logs. This increase is required to address this issue.

Testing
make verify-prowjobs succeeds.

make verify-prowjobs -C templater
go fmt ./...
go generate ./...
go vet ./...
go build -o ./bin/generate-prowjobs github.com/aws/eks-distro-prow-jobs/templater
./bin/generate-prowjobs
./scripts/verify-prowjobs.sh

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants