fix(jsii-pacmak): --mvn-* arguments aren't passed through
#5018
+64
−42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR is the correct fix for #5015. `jsii-pacmak` has a feature where `--mvn-settings=X` is passed through as `--settings=X` when calling `mvn`. This was not being passed through in the call to the new `resolve-ranges` step. This PR factors the entire Maven invocation into a helper that contains that logic, and uses it from 2 call sites. Not sure about the best way to automatically test this, so for now this doesn't have a test.
mrgrain
approved these changes
Jan 2, 2026
Contributor
|
Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it! |
Contributor
|
Merging (with squash)... |
Contributor
Merge Queue Status✅ The pull request has been merged at 5dad6e1 This pull request spent 5 seconds in the queue, with no time running CI. Required conditions to merge
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the correct fix for #5015.
jsii-pacmakhas a feature where--mvn-settings=Xis passed through as--settings=Xwhen callingmvn.This was not being passed through in the call to the new
resolve-rangesstep. This PR factors the entire Maven invocation into a helper that contains that logic, and uses it from 2 call sites.Not sure about the best way to automatically test this, so for now this doesn't have a test.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.