Skip to content

Commit

Permalink
Add support for Bottlerocket FIPS AMIs
Browse files Browse the repository at this point in the history
  • Loading branch information
aufomin committed Feb 20, 2025
1 parent 4201bc9 commit 69538a8
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 0 deletions.
2 changes: 2 additions & 0 deletions pkg/controllers/nodeclass/ami_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -305,6 +305,8 @@ var _ = Describe("NodeClass AMI Status Controller", func() {
fmt.Sprintf("/aws/service/bottlerocket/aws-k8s-%s/arm64/latest/image_id", k8sVersion): "ami-arm64-standard",
fmt.Sprintf("/aws/service/bottlerocket/aws-k8s-%s-nvidia/x86_64/latest/image_id", k8sVersion): "ami-amd64-nvidia",
fmt.Sprintf("/aws/service/bottlerocket/aws-k8s-%s-nvidia/arm64/latest/image_id", k8sVersion): "ami-arm64-nvidia",
fmt.Sprintf("/aws/service/bottlerocket/aws-k8s-%s-fips/x86_64/latest/image_id", k8sVersion): "ami-arm64-nvidia",
fmt.Sprintf("/aws/service/bottlerocket/aws-k8s-%s-fips/arm64/latest/image_id", k8sVersion): "ami-arm64-nvidia",
}
nodeClass.Spec.AMISelectorTerms = []v1.AMISelectorTerm{{Alias: "bottlerocket@latest"}}
ExpectApplied(ctx, env.Client, nodeClass)
Expand Down
2 changes: 2 additions & 0 deletions pkg/providers/amifamily/bottlerocket.go
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,8 @@ func (b Bottlerocket) DescribeImageQuery(ctx context.Context, ssmProvider ssm.Pr
fmt.Sprintf("/aws/service/bottlerocket/aws-k8s-%s/arm64/%s/image_id", k8sVersion, trimmedAMIVersion): {VariantStandard},
fmt.Sprintf("/aws/service/bottlerocket/aws-k8s-%s-nvidia/x86_64/%s/image_id", k8sVersion, trimmedAMIVersion): {VariantNvidia},
fmt.Sprintf("/aws/service/bottlerocket/aws-k8s-%s-nvidia/arm64/%s/image_id", k8sVersion, trimmedAMIVersion): {VariantNvidia},
fmt.Sprintf("/aws/service/bottlerocket/aws-k8s-%s-fips/x86_64/%s/image_id", k8sVersion, trimmedAMIVersion): {VariantFips},
fmt.Sprintf("/aws/service/bottlerocket/aws-k8s-%s-fips/arm64/%s/image_id", k8sVersion, trimmedAMIVersion): {VariantFips},
} {
imageID, err := ssmProvider.Get(ctx, ssm.Parameter{
Name: path,
Expand Down
4 changes: 4 additions & 0 deletions pkg/providers/amifamily/suite_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,8 @@ const (
arm64AMI = "arm64-ami-id"
amd64NvidiaAMI = "amd64-nvidia-ami-id"
arm64NvidiaAMI = "arm64-nvidia-ami-id"
amd64FipsAMI = "amd64-fips-ami-id"
arm64FipsAMI = "arm64-fips-ami-id"
)

var _ = BeforeSuite(func() {
Expand Down Expand Up @@ -166,6 +168,8 @@ var _ = Describe("AMIProvider", func() {
fmt.Sprintf("/aws/service/bottlerocket/aws-k8s-%s-nvidia/x86_64/latest/image_id", version): amd64NvidiaAMI,
fmt.Sprintf("/aws/service/bottlerocket/aws-k8s-%s/arm64/latest/image_id", version): arm64AMI,
fmt.Sprintf("/aws/service/bottlerocket/aws-k8s-%s-nvidia/arm64/latest/image_id", version): arm64NvidiaAMI,
fmt.Sprintf("/aws/service/bottlerocket/aws-k8s-%s-fips/x86_64/latest/image_id", version): amd64AMI,
fmt.Sprintf("/aws/service/bottlerocket/aws-k8s-%s-fips/arm64/latest/image_id", version): arm64FipsAMI,
}
amis, err := awsEnv.AMIProvider.List(ctx, nodeClass)
Expect(err).ToNot(HaveOccurred())
Expand Down
1 change: 1 addition & 0 deletions pkg/providers/amifamily/types.go
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,7 @@ var (
VariantStandard Variant = "standard"
VariantNvidia Variant = "nvidia"
VariantNeuron Variant = "neuron"
VariantFips Variant = "fips"
maxTime time.Time = time.Unix(math.MaxInt64, 0)
minTime time.Time = time.Unix(math.MinInt64, 0)
)
Expand Down

0 comments on commit 69538a8

Please sign in to comment.