-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Get Neuron device and core count from EC2 API for all trn*
and inf*
instance types
#6510
Conversation
✅ Deploy Preview for karpenter-docs-prod ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
3d1b8da
to
e894f8a
Compare
This PR has been inactive for 14 days. StaleBot will close this stale PR after 14 more days of inactivity. |
This PR has been inactive for 14 days. StaleBot will close this stale PR after 14 more days of inactivity. |
Any update here? |
d48abe9
to
f5fdc84
Compare
Pull Request Test Coverage Report for Build 11620786418Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
This PR has been inactive for 14 days. StaleBot will close this stale PR after 14 more days of inactivity. |
06c6bbb
to
964090e
Compare
964090e
to
3677253
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Going to let the integration tests run and we should be go to merge
/karpenter snapshot
Snapshot successfully published to
|
18c3450
to
d5b11a9
Compare
…nf*` instance types
…populated correctly
…nded resource test
d5b11a9
to
dc2aa66
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/karpenter snapshot
Snapshot successfully published to
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
…euron accelerator name well known label
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay, one suggested update but other than that this looks good to me
Co-authored-by: Jason Deal <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Fixes #3555
Description
trn*
static resource definitions and instead pulls directly from EC2 API to get device count, core count, and total device memoryinf*
resource requirement collection fromInferenceAcceleratorInfo
toNeuronInfo
; this aligns withtrn*
resource information collection for all Neuron related resource informationNeuronInfo
supersedesInferenceAcceleratorInfo
:aws ec2 describe-instance-types --query 'InstanceTypes[*].NeuronInfo'
aws ec2 describe-instance-types --query 'InstanceTypes[*].InferenceAcceleratorInfo'
aws.amazon.com/neuroncore
which is used for allocating neuron cores to the containerus-east-2
to collect instance details for the reference instance types doc page that are not found inus-east-1
norus-west-2
make codegen
andmake docgen
How was this change tested?
make test
Does this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.