Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict auto-mount of service account token in service account #7606

Merged
merged 1 commit into from
Feb 10, 2025

Conversation

michalschott
Copy link
Contributor

Fixes #N/A

Description
Kubernetes automatically mounts ServiceAccount credentials in each ServiceAccount. The ServiceAccount may be assigned roles allowing Pods to access API resources. Blocking this ability is an extension of the least privilege best practice and should be followed if Pods do not need to speak to the API server to function.

Obviously Karpenter relies on this, so token is mounted to it's pods (set on deployment level).

How was this change tested?
Custom EKS cluster

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@michalschott michalschott requested a review from a team as a code owner January 16, 2025 11:25
Copy link

netlify bot commented Jan 16, 2025

Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit 38869c9
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/67a998f709e4d70008920579

@jmdeal jmdeal added the help-wanted Extra attention is needed label Jan 27, 2025
Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jonathan-innis
Copy link
Contributor

Makes sense to me!

Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

@coveralls
Copy link

coveralls commented Feb 7, 2025

Pull Request Test Coverage Report for Build 13234701530

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 64.766%

Totals Coverage Status
Change from base Build 13213523731: 0.0%
Covered Lines: 5803
Relevant Lines: 8960

💛 - Coveralls

Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

@jonathan-innis jonathan-innis enabled auto-merge (squash) February 10, 2025 23:45
@jonathan-innis jonathan-innis merged commit d07ba3f into aws:main Feb 10, 2025
17 checks passed
edibble21 pushed a commit to edibble21/karpenter-provider-aws that referenced this pull request Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help-wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants