chore: Add ability to the helm chart to specify initContainers. #7668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the current helm chart does not support adding initContainers to the deployment for things like ensuring that IAM credentials are valid. This PR aims to support users to especify initContainers in the Values file. The implementation follows the practices applied in other similar fields that are already present.
✅ Deploy Preview for karpenter-docs-prod canceled.
|
| @@ -68,6 +68,11 @@ dnsConfig: {} | |||
| # options: | |||
| # - name: ndots | |||
| # value: "1" | |||
| # -- add additional initContainers to run before karpenter container starts | |||
| initContainers: {} | |||
There was a problem hiding this comment.
This is an interesting use-case. Why can't you just ensure that your permissions are correct (and/or) see the failure once Karpenter starts OR rely on something like #7624 to ensure this
There was a problem hiding this comment.
Validating IAM Credentials is one common use of initContainers and the one we want to check (and for which #7624 may help), but initContainers can also be used for other use cases specific to each cluster maintainer's needs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #N/A
Description
Currently, the helm chart does not support adding initContainers to the deployment for things like ensuring that IAM credentials are valid.
This PR aims to add support for users in specifying initContainers in the Values file.
The implementation follows the practices applied in other similar fields that are already present.
Does this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.