Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add a binary makefile target #7704

Merged
merged 2 commits into from
Feb 7, 2025

Conversation

elmiko
Copy link
Contributor

@elmiko elmiko commented Feb 6, 2025

Fixes #7702

Description

this change adds an option in the makefile to build only the binary version of the controller using the go build command. It also adds a line to the gitignore file to help prevent adding the built binary to the repository.

How was this change tested?

ran the makefile target to ensure proper build with no errors.

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

this change adds an option in the makefile to build only the binary
version of the controller using the `go build` command. It also adds a
line to the gitignore file to help prevent adding the built binary to
the repository.
@elmiko elmiko requested a review from a team as a code owner February 6, 2025 14:40
@elmiko elmiko requested a review from tzneal February 6, 2025 14:40
Copy link

netlify bot commented Feb 6, 2025

Deploy Preview for karpenter-docs-prod ready!

Name Link
🔨 Latest commit 3b4b758
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/67a5a89e9570bb000884f4a0
😎 Deploy Preview https://deploy-preview-7704--karpenter-docs-prod.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jonathan-innis jonathan-innis enabled auto-merge (squash) February 7, 2025 05:47
@coveralls
Copy link

coveralls commented Feb 7, 2025

Pull Request Test Coverage Report for Build 13194522129

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 64.926%

Files with Coverage Reduction New Missed Lines %
pkg/fake/utils.go 2 94.81%
Totals Coverage Status
Change from base Build 13191304092: -0.02%
Covered Lines: 5805
Relevant Lines: 8941

💛 - Coveralls

@jonathan-innis jonathan-innis merged commit eeac9df into aws:main Feb 7, 2025
17 checks passed
@elmiko elmiko deleted the add-binary-makefile-target branch February 7, 2025 13:45
edibble21 pushed a commit to edibble21/karpenter-provider-aws that referenced this pull request Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

karpenter makefile could use a binary-only target
3 participants