-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: Remove calling List on NodeClaims and Nodes in interruption controller #7707
perf: Remove calling List on NodeClaims and Nodes in interruption controller #7707
Conversation
✅ Deploy Preview for karpenter-docs-prod canceled.
|
14cd57d
to
4a69767
Compare
4a69767
to
2bca455
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/karpenter snapshot
Pull Request Test Coverage Report for Build 13194826151Details
💛 - Coveralls |
Snapshot successfully published to
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Fixes #N/A
Description
This change removes the construction of the NodeClaim instanceID map and the Node instanceID map -- this was expensive to construct and was re-constructed on every requeue of the interruption controller. Rather than constructing the mapping this way, we can use a field indexer on instanceID and look-up the NodeClaim and Nodes add-hoc by performing a matchField list query against the internal read cache
How was this change tested?
make presubmit
/karpenter snapshot
Does this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.