Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Bottlerocket on Neuron instance types #7722

Merged
merged 2 commits into from
Feb 21, 2025

Conversation

vigh-m
Copy link
Contributor

@vigh-m vigh-m commented Feb 10, 2025

Fixes #7596

Description
This changes allows karpenter to launch Neuron instances (inf, trn instance types) using the Bottlerocket AMI.

How was this change tested?

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@vigh-m vigh-m requested a review from a team as a code owner February 10, 2025 20:52
@vigh-m vigh-m requested a review from tzneal February 10, 2025 20:52
Copy link

netlify bot commented Feb 10, 2025

Deploy Preview for karpenter-docs-prod ready!

Name Link
🔨 Latest commit ff5a129
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/67b65973b4508600080555ed
😎 Deploy Preview https://deploy-preview-7722--karpenter-docs-prod.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@vigh-m vigh-m changed the title Enable neuron Add support for Bottlerocket on Neuron instance types Feb 10, 2025
@vigh-m
Copy link
Contributor Author

vigh-m commented Feb 13, 2025

⬆️ Pushed updates following comments

@coveralls
Copy link

coveralls commented Feb 18, 2025

Pull Request Test Coverage Report for Build 13423495209

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 65.215%

Totals Coverage Status
Change from base Build 13381487008: 0.0%
Covered Lines: 5977
Relevant Lines: 9165

💛 - Coveralls

@vigh-m
Copy link
Contributor Author

vigh-m commented Feb 19, 2025

⬆️ Pushed changes to BottlerockerSettings to support the new setting option

Copy link
Contributor

@rschalo rschalo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rschalo rschalo merged commit 9e48f2f into aws:main Feb 21, 2025
19 checks passed
brian-villa pushed a commit to brian-villa/karpenter-provider-aws that referenced this pull request Feb 24, 2025
rschalo pushed a commit to rschalo/karpenter-provider-aws that referenced this pull request Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Enable launching Bottlerocket AMIs on AWS Neuron Instances
4 participants