Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: bump go to 1.24.0 #7733

Merged
merged 1 commit into from
Feb 13, 2025
Merged

deps: bump go to 1.24.0 #7733

merged 1 commit into from
Feb 13, 2025

Conversation

jmdeal
Copy link
Contributor

@jmdeal jmdeal commented Feb 12, 2025

Fixes #N/A

Description
Bumps go to 1.24.0.

How was this change tested?
make presubmit

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jmdeal jmdeal requested a review from a team as a code owner February 12, 2025 18:17
Copy link

netlify bot commented Feb 12, 2025

Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit 6882a4d
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/67ae2668a0a0410008a694f3

@jmdeal jmdeal added the blocked Unable to make progress due to some dependency label Feb 12, 2025
@jmdeal
Copy link
Contributor Author

jmdeal commented Feb 12, 2025

Going to block the PR until 1.24 is available in brew since most maintainers use brew for dependency management, and there isn't a pressing need to get this version bump in.

@jmdeal jmdeal removed the blocked Unable to make progress due to some dependency label Feb 13, 2025
@coveralls
Copy link

coveralls commented Feb 13, 2025

Pull Request Test Coverage Report for Build 13313099722

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 65.215%

Files with Coverage Reduction New Missed Lines %
pkg/fake/utils.go 2 94.81%
Totals Coverage Status
Change from base Build 13296342952: -0.02%
Covered Lines: 5977
Relevant Lines: 9165

💛 - Coveralls

Copy link
Contributor

@rschalo rschalo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmdeal jmdeal merged commit 75f4322 into aws:main Feb 13, 2025
18 checks passed
edibble21 pushed a commit to edibble21/karpenter-provider-aws that referenced this pull request Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants