Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed deprecated metrics from documentation (#7740) #7755

Open
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

brian-villa
Copy link

Removed all metrics labeled as DEPRECATED from the documentation as suggested in issue #7740.

@brian-villa brian-villa requested a review from a team as a code owner February 20, 2025 12:13
Copy link

netlify bot commented Feb 20, 2025

Deploy Preview for karpenter-docs-prod ready!

Name Link
🔨 Latest commit 60636cd
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/67bc804c07a7120008291728
😎 Deploy Preview https://deploy-preview-7755--karpenter-docs-prod.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@@ -155,16 +155,6 @@ Pod state is the current state of pods. This metric can be used several ways as
The time from pod creation until the pod is running.
- Stability Level: STABLE

## Termination Metrics
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We auto-gen all of this documentation with make docgen -- if you were to run that, I think it would remove your changes -- I think you need to make a change to the metrics_gen script file to get this to work

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I will check it

@brian-villa brian-villa deleted the issue_#7740 branch February 24, 2025 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants