-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed deprecated metrics from documentation (#7740) #7755
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for karpenter-docs-prod ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@@ -155,16 +155,6 @@ Pod state is the current state of pods. This metric can be used several ways as | |||
The time from pod creation until the pod is running. | |||
- Stability Level: STABLE | |||
|
|||
## Termination Metrics |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We auto-gen all of this documentation with make docgen
-- if you were to run that, I think it would remove your changes -- I think you need to make a change to the metrics_gen
script file to get this to work
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, I will check it
…ns/install-deps in the action-deps group across 1 directory (aws#7789) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…actions-deps group across 1 directory (aws#7790) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Removed all metrics labeled as DEPRECATED from the documentation as suggested in issue #7740.