Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: webhook configurations for upgrade to v1 #7757

Merged
merged 1 commit into from
Feb 21, 2025

Conversation

drmorr0
Copy link
Contributor

@drmorr0 drmorr0 commented Feb 21, 2025

Description

Adding a note to the upgrade docs for people not using helm to upgrade that some manual cleanup of the webhook configuraitons may be necessary. There are a number of closed issues (e.g. #7134, #6982, #6879) where it seems like people are running into this so seems like maybe a helpful note to have.

How was this change tested?
Built the docs locally:

image

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@drmorr0 drmorr0 requested a review from a team as a code owner February 21, 2025 00:05
@drmorr0 drmorr0 requested a review from engedaam February 21, 2025 00:05
Copy link

netlify bot commented Feb 21, 2025

Deploy Preview for karpenter-docs-prod ready!

Name Link
🔨 Latest commit 3163004
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/67b801ce9a13f50008f7bd3c
😎 Deploy Preview https://deploy-preview-7757--karpenter-docs-prod.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@drmorr0 drmorr0 force-pushed the drmorr/update-webhooks-docs branch from 9e0cb21 to 9f8bd51 Compare February 21, 2025 04:31
@drmorr0 drmorr0 requested a review from engedaam February 21, 2025 04:31
@drmorr0 drmorr0 force-pushed the drmorr/update-webhooks-docs branch from 9f8bd51 to 3163004 Compare February 21, 2025 04:32
@jonathan-innis
Copy link
Contributor

jonathan-innis commented Feb 21, 2025

Adding a note to the upgrade docs for people not using helm to upgrade that some manual cleanup of the webhook configuraitons may be necessary

I'm still surprised why folks are running into this -- I'm not against adding this to the docs, but my understanding is that if you are running with prune, then the fix that dropped the ownerReferences should ensure that these webhooks don't stick around after the upgrade

I'm realizing that helm template doesn't help you in this scenario; though, this seems like a dangerous thing to use if we were to just drop something down the line -- this could be leaked. Note makes sense though. Thanks for adding!

Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jonathan-innis jonathan-innis enabled auto-merge (squash) February 21, 2025 16:52
@jonathan-innis jonathan-innis merged commit d831d55 into aws:main Feb 21, 2025
17 checks passed
@coveralls
Copy link

Pull Request Test Coverage Report for Build 13450088284

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 65.215%

Files with Coverage Reduction New Missed Lines %
pkg/fake/utils.go 2 94.81%
Totals Coverage Status
Change from base Build 13447487814: -0.02%
Covered Lines: 5977
Relevant Lines: 9165

💛 - Coveralls

brian-villa pushed a commit to brian-villa/karpenter-provider-aws that referenced this pull request Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants