-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: webhook configurations for upgrade to v1 #7757
Conversation
✅ Deploy Preview for karpenter-docs-prod ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
9e0cb21
to
9f8bd51
Compare
9f8bd51
to
3163004
Compare
I'm realizing that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Pull Request Test Coverage Report for Build 13450088284Details
💛 - Coveralls |
Description
Adding a note to the upgrade docs for people not using
helm
to upgrade that some manual cleanup of the webhook configuraitons may be necessary. There are a number of closed issues (e.g. #7134, #6982, #6879) where it seems like people are running into this so seems like maybe a helpful note to have.How was this change tested?
Built the docs locally:
Does this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.