-
Notifications
You must be signed in to change notification settings - Fork 1.1k
chore: Add relabeling and metricRelabeling to Service Monitor in Karpenter Helm Chart #7794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for karpenter-docs-prod canceled.
|
@waruwat-dev Can you walk me through |
Pull Request Test Coverage Report for Build 15151860817Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Exactly what we need now. We want to have karpenter metrics, but it's also exposing metrics we do not care about for instance: karpenter_cloudprovider_instance_type_offering_price_estimate which is basically AWS pricing inside metrics with almost 5000 data points for each scrape We have many clusters, we don't need that metrics from each of them (data is the same) and in fact we want to drop it completely. Second usecase is, by default karpenter metrics do have many labels (more than 30) which is more than some stacks (like mimir) allow for by default. Droping some labels is what we do for some other helm charts after carefull review, but typicall helm charts allow for that. Karpenter one does not. |
1527cd3
to
e504160
Compare
✅ Deploy Preview for karpenter-docs-prod canceled.
|
e504160
to
d347da0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Fixes #N/A
Description
This merge request enhances the ServiceMonitor in the Karpenter Helm Chart by adding support for relabeling and metricRelabeling. This allows users to modify labels and filter metrics before they are scraped by Prometheus.
Motivation
In some cases, users need to adjust labels or refine metrics to align with their existing monitoring setup.
Prometheus provides relabel_configs and metric_relabel_configs to modify or filter metrics dynamically, but the Karpenter Helm Chart currently lacks the ability to configure these options.
Changes Introduced
How was this change tested?
Does this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.