Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: auto-detect Kubernetes version in migration from cas setup #7843

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

omerap12
Copy link
Member

@omerap12 omerap12 commented Mar 5, 2025

Fixes #N/A

Description
The migration guide from CAS (link) currently includes a hardcoded Kubernetes version:

K8S_VERSION=1.28

To improve flexibility and ensure compatibility with different cluster versions, this has been updated to dynamically fetch the Kubernetes version from the EKS cluster using:

K8S_VERSION=$(aws eks describe-cluster --name "${CLUSTER_NAME}" --query "cluster.version" --output text)

How was this change tested?

~/ aws eks describe-cluster --name "${CLUSTER_NAME}" --query "cluster.version" --output text --no-cli-pager
1.32

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@omerap12 omerap12 requested a review from a team as a code owner March 5, 2025 09:20
@omerap12 omerap12 requested a review from jigisha620 March 5, 2025 09:20
Copy link

netlify bot commented Mar 5, 2025

Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit d52c057
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/67c81855de8fa50008e16c15

@omerap12 omerap12 changed the title auto-detect Kubernetes version in Karpenter AWS provider setup docs: auto-detect Kubernetes version in Karpenter AWS provider setup Mar 5, 2025
@omerap12 omerap12 changed the title docs: auto-detect Kubernetes version in Karpenter AWS provider setup docs: auto-detect Kubernetes version in migration for cas setup Mar 5, 2025
@omerap12 omerap12 changed the title docs: auto-detect Kubernetes version in migration for cas setup docs: auto-detect Kubernetes version in migration from cas setup Mar 5, 2025
@coveralls
Copy link

coveralls commented Mar 5, 2025

Pull Request Test Coverage Report for Build 13672636141

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 67.131%

Totals Coverage Status
Change from base Build 13669133528: 0.0%
Covered Lines: 6746
Relevant Lines: 10049

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants