Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: spurious logging from capacity reservation controller #7847

Merged
merged 2 commits into from
Mar 5, 2025
Merged

fix: spurious logging from capacity reservation controller #7847

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a68b1c1
fix: spurious logging from capacity reservation controller
rschalo Mar 5, 2025
7aae4e8
address nodeclaim as well
rschalo Mar 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion pkg/controllers/nodeclaim/capacityreservation/controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,7 @@ func (c *Controller) syncCapacityType(ctx context.Context, capacityType string,
if err != nil {
return false, fmt.Errorf("listing nodes for nodeclaim %q, %w", nc.Name, err)
}
updated := false
for _, n := range nodes {
if !n.DeletionTimestamp.IsZero() {
continue
Expand All @@ -148,6 +149,7 @@ func (c *Controller) syncCapacityType(ctx context.Context, capacityType string,
if err := c.kubeClient.Patch(ctx, n, client.MergeFrom(stored)); client.IgnoreNotFound(err) != nil {
return false, fmt.Errorf("patching node %q, %w", n.Name, err)
}
updated = true
}
return true, nil
return updated, nil
}