Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Drop some old compat notices that no longer apply #7854

Merged
merged 1 commit into from
Mar 6, 2025

Conversation

jonathan-innis
Copy link
Contributor

Fixes #N/A

Description

There are some compatibility notices that are either for versions of K8s that we don't formally document that we support anymore (because they are quite old at this point) OR that are not outright supported by the latest versions of Karpenter (like webhooks)

How was this change tested?

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jonathan-innis jonathan-innis requested a review from a team as a code owner March 6, 2025 05:11
Copy link

netlify bot commented Mar 6, 2025

Deploy Preview for karpenter-docs-prod ready!

Name Link
🔨 Latest commit b6695fd
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/67c92f4f0ff4390008c39c21
😎 Deploy Preview https://deploy-preview-7854--karpenter-docs-prod.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jonathan-innis jonathan-innis enabled auto-merge (squash) March 6, 2025 05:12
@jonathan-innis jonathan-innis force-pushed the drop-old-compat-notices branch from 2c42e59 to b6695fd Compare March 6, 2025 05:14
@coveralls
Copy link

coveralls commented Mar 6, 2025

Pull Request Test Coverage Report for Build 13691757070

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.01%) to 67.126%

Files with Coverage Reduction New Missed Lines %
pkg/providers/instance/instance.go 1 91.97%
Totals Coverage Status
Change from base Build 13691560594: -0.01%
Covered Lines: 6767
Relevant Lines: 10081

💛 - Coveralls

Copy link
Contributor

@rschalo rschalo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonathan-innis jonathan-innis merged commit 6e92379 into aws:main Mar 6, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants