Skip to content

docs: add description when the nodepool limit was not set #7879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 21, 2025

Conversation

Vacant2333
Copy link
Contributor

Fixes #N/A

Description

How was this change tested?

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@Vacant2333 Vacant2333 requested a review from a team as a code owner March 12, 2025 06:58
@Vacant2333 Vacant2333 requested a review from engedaam March 12, 2025 06:58
Copy link

netlify bot commented Mar 12, 2025

Deploy Preview for karpenter-docs-prod ready!

Name Link
🔨 Latest commit 70d9733
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/6819ccc790c9ce00083b6ecb
😎 Deploy Preview https://deploy-preview-7879--karpenter-docs-prod.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@maxsxu maxsxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Vacant2333
Copy link
Contributor Author

@engedaam @jonathan-innis hi, can u help me review?

@Vacant2333 Vacant2333 changed the title docs: add description when the limits were not set docs: add description when the nodepool limit was not set Mar 20, 2025
@engedaam engedaam self-assigned this Apr 7, 2025
Copy link
Contributor

@engedaam engedaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Vacant2333 Can you make this change to all the version in the docs?

@Vacant2333 Vacant2333 force-pushed the main branch 2 times, most recently from beac303 to 2ef5ec3 Compare May 6, 2025 02:42
@Vacant2333
Copy link
Contributor Author

@Vacant2333 Can you make this change to all the version in the docs?

Thanks for your review, i have update it now

Copy link
Contributor

@engedaam engedaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@coveralls
Copy link

Pull Request Test Coverage Report for Build 14855465023

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 66.735%

Totals Coverage Status
Change from base Build 14842018007: 0.0%
Covered Lines: 6879
Relevant Lines: 10308

💛 - Coveralls

Copy link

@maxsxu maxsxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work!

Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jonathan-innis jonathan-innis merged commit d8b577d into aws:main May 21, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants