fix: Fix EC2NodeClass readiness to not stuck in False #7970
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We observed some EC2NodeClasses stuck in Ready=False with message of `Failed to detect the cluster CIDR`. We believe this is caused by a bug in Karpenter, and this commit fixes that. The previous commit adds a failing test to reproduce and the demonstrate the issue, and this commit fixes the implementation.
mumoshu
force-pushed
the
nodeclass-readiness-will-be-back
branch
from
f2242bc to
c6c42a7
Compare
✅ Deploy Preview for karpenter-docs-prod canceled.
|
✅ Deploy Preview for karpenter-docs-prod canceled.
|
|
Thanks for opening this @mumoshu! Take a look at the feedback that I gave here: https://github.com/aws/karpenter-provider-aws/pull/7965/files#r2024015633. I think we should move this to the validation controller. |
jonathan-innis
added
lifecycle/stale
triage/needs-information
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7875
Description
We observed some EC2NodeClasses stuck in Ready=False with message of
Failed to detect the cluster CIDR. We believe this is caused by an issue in Karpenter when EKS API failed temporarily, and this PR fixes that.I noticed this is just another way to fix the same issue the PR #7965 by @AlexeyPetroff trying to solve!
How was this change tested?
The first commit adds a failing test case, and the second commit fixes the implementation to let the test pass.
Does this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.