feat: Dynamic EBS volumeSize
in EC2NodeClass
#8024
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8023
Summary:
This pull request enhances the
EC2NodeClass
functionality by allowing thevolumeSize
field to be dynamically calculated based on the number of CPUs in the node. This change introduces flexibility in configuring EBS volume sizes, reducing disk space waste and simplifying configuration.Changes:
Dynamic Volume Size Calculation:
CalculateVolumeSize
function now supports parsing thevolumeSize
field to calculate the size dynamically using theCPU
keyword.volumeSize: "10Gi * CPU"
calculates the volume size as10Gi
multiplied by the number of CPUs in the node.volumeSize: "20Gi"
are still supported for backward compatibility.Unit Tests:
ec2nodeclass_test.go
to validate the behavior of theCalculateVolumeSize
function.Benefits:
EC2NodeClass
definitions for different node sizes, streamlining configuration.Testing:
go test ./pkg/apis/v1 -v
Does this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.