fix: Fix sheduling test to account for ENIs created by VPC CNI#9182
Open
jaydeokar wants to merge 1 commit into
Open
fix: Fix sheduling test to account for ENIs created by VPC CNI#9182jaydeokar wants to merge 1 commit into
jaydeokar wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Pull request overview
Adjusts the EFA scheduling integration test to be resilient to additional ENIs created asynchronously by the VPC CNI, avoiding timing-dependent flakes in the scheduling suite.
Changes:
- Relax the test assertion from “exactly 2 ENIs” to “at least 2 ENIs” while still validating the presence and types of device indexes 0 and 1.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #N/A
N/A
Description
EFA scheduling test is expecting only 2 ENIs whereas after the 1st pod lands, due to VPC CNI scaling the third ENI is added. As a result, the outcome depends on the timing of the DescribeInstances call - whether it happens before or after the CNI scale-up occurs.
How was this change tested?
Does this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.