docs: make compatibility-matrix generation idempotent + dedupe rows - #9398
Draft
DerekFrank wants to merge 1 commit into
Draft
docs: make compatibility-matrix generation idempotent + dedupe rows#9398DerekFrank wants to merge 1 commit into
DerekFrank wants to merge 1 commit into
Conversation
version_compatibility_gen appends the release's version to compatibility.yaml on every release, unconditionally. Re-tags and re-runs therefore accumulate duplicate rows — 1.12.x and 1.14.x each ended up listed twice. - Skip the append when the version's appVersion row is already present (idempotent). - Remove the existing duplicate 1.12.x and 1.14.x entries and regenerate compatibility.md. Verified: re-running for an existing version is now a no-op; a new version appends exactly once.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
hack/docs/version_compatibility_genruns on every release and unconditionally appends the release version tocompatibility.yaml. Re-tags and re-runs accumulate duplicate rows — onmaintoday, 1.12.x and 1.14.x each appear twice.Fix
appVersion: X.Y.xrow is already present.compatibility.mdfrom the deduped source is a no-op (the rendered matrix collapses by minimum version), so no doc churn.Testing (local)
go vetpasses.Relates to the release-process retro item on keeping the compatibility matrix correct at release time.