chore: add options to start VSCode client with unencrypted connection #788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -172,11 +172,11 @@ export async function activateDocumentsLanguageServer(extensionContext: Extensio | |||
| const client = new LanguageClient('awsDocuments', 'AWS Documents Language Server', serverOptions, clientOptions) | |||
|
|
|||
| if (enableIamProvider) { | |||
| await registerIamCredentialsProviderSupport(client, extensionContext) | |||
| await registerIamCredentialsProviderSupport(client, extensionContext, enableEncryptionInit) | |||
There was a problem hiding this comment.
at some point does it make sense to just create a config class or a .env that evaluates the env vars for you? That way you don't have to pass this around everywhere and can just do: getEncryption()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
VSCode sample client works only with encrypted connection to Language Server runtime.
Solution
Allow to start unencrypted connection, controlled with
ENABLE_ENCRYPTIONenv variable.License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.