Skip to content
This repository was archived by the owner on Oct 4, 2022. It is now read-only.

Bad render target in snow displacement #449

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Bad render target in snow displacement #449

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8120c1d
Bug fix - bad render target in snow displacement
yuriy0 Dec 3, 2019
8a0ba27
Typo - fix function syntax
yuriy0 Dec 3, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions dev/Code/CryEngine/RenderDll/XRenderD3D9/D3DDeferredPasses.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -673,6 +673,8 @@ bool CD3D9Renderer::FX_DeferredRainGBuffer()
////////////////////////////////////////////////////////////////////////////////////////////////////
////////////////////////////////////////////////////////////////////////////////////////////////////

static CTexture* s_snowDisplacement = nullptr;

bool CD3D9Renderer::FX_DeferredSnowLayer()
{
const SSnowParams& snowVolParams = m_p3DEngineCommon.m_SnowInfo;
Expand All @@ -692,6 +694,15 @@ bool CD3D9Renderer::FX_DeferredSnowLayer()
return false;
}

if (!s_snowDisplacement || s_snowDisplacement->GetWidth() != CTexture::s_ptexSceneDiffuse->GetWidth() || s_snowDisplacement->GetHeight() != CTexture::s_ptexSceneDiffuse->GetHeight())
{
SD3DPostEffectsUtils::CreateRenderTarget(
"$SnowDisplacement", s_snowDisplacement,
CTexture::s_ptexSceneDiffuse->GetWidth(), CTexture::s_ptexSceneDiffuse->GetHeight(),
Clr_Empty, true, false, eTF_R8G8B8A8, -1, FT_DONT_STREAM | FT_USAGE_RENDERTARGET
);
}

PROFILE_LABEL_SCOPE("DEFERRED_SNOW_ACCUMULATION");

if (!gcpRendD3D->FX_GetEnabledGmemPath(nullptr)) // needed RTs already in GMEM
Expand All @@ -704,10 +715,9 @@ bool CD3D9Renderer::FX_DeferredSnowLayer()
gcpRendD3D->FX_PushRenderTarget(0, CTexture::s_ptexSceneDiffuse, &gcpRendD3D->m_DepthBufferOrigMSAA);
gcpRendD3D->FX_PushRenderTarget(1, CTexture::s_ptexSceneNormalsMap, NULL);
gcpRendD3D->FX_PushRenderTarget(2, CTexture::s_ptexSceneSpecular, NULL);

if (CRenderer::CV_r_snow_displacement)
{
gcpRendD3D->FX_PushRenderTarget(3, CTexture::s_ptexStereoR, NULL);
gcpRendD3D->FX_PushRenderTarget(3, s_snowDisplacement, NULL);
}
}
else
Expand Down Expand Up @@ -815,7 +825,6 @@ bool CD3D9Renderer::FX_DeferredSnowLayer()
gcpRendD3D->FX_PopRenderTarget(0);
gcpRendD3D->FX_PopRenderTarget(1);
gcpRendD3D->FX_PopRenderTarget(2);

if (CRenderer::CV_r_snow_displacement)
{
gcpRendD3D->FX_PopRenderTarget(3);
Expand Down Expand Up @@ -891,7 +900,7 @@ bool CD3D9Renderer::FX_DeferredSnowDisplacement()

pShader->FXSetPSFloat(param5Name, (Vec4*)matView.GetData(), 3);

PostProcessUtils().SetTexture(CTexture::s_ptexStereoR, 0, FILTER_POINT);
PostProcessUtils().SetTexture(s_snowDisplacement, 0, FILTER_POINT);

SD3DPostEffectsUtils::DrawFullScreenTri(CTexture::s_ptexBackBuffer->GetWidth(), CTexture::s_ptexBackBuffer->GetHeight());

Expand Down