adding-rg-phase1#182
Merged
Merged
Conversation
Contributor
|
LGTM. Thank you Ricardo! |
Brandon-Schur
approved these changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Adds support for the new Amazon Redshift rg instance types (rg.xlarge and rg.4xlarge) to the Node Configuration Comparison utility.
Changes:
RedshiftConfigTestingLambda.py: Added rg.xlarge and rg.4xlarge to the allowed node types validation list
README.md: Added rg.xlarge and rg.4xlarge to the NODE_TYPE valid values documentation
user_config.json: Updated example configuration to use rg.xlarge instead of dc2.8xlarge
Testing:
Deployed via CloudFormation and ran the Step Function end-to-end with rg.xlarge (2 nodes)
Validation logic correctly accepts rg types
Cluster creation follows the restore + classic resize path successfully
Notes:
rg.large and rg.12xlarge are not included as they are not yet launched
rg instance types require a minimum of 2 nodes (single-node is not supported)
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.