avoid waker clones #3748
Open
avoid waker clones #3748
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR, we'll have a look |
|
Spoke offline; we're going to look into requiring passing |
arielb1
force-pushed
the
avoid-waker-clones
branch
from
fa07eba to
14cd3ed
Compare
|
updated |
|
bindings changed- needs merge conflicts addressed. |
arielb1
force-pushed
the
avoid-waker-clones
branch
from
13b6982 to
3317003
Compare
We have an internal application that uses s2n from different tasks (one for transmitting, one for receiving), and before this CR, this caused s2n to always clone the wakers and suffer from bad performance. This change notices that the transmitted context can always be passed down the stack, and improves performance in our case by about ~5%.
arielb1
force-pushed
the
avoid-waker-clones
branch
from
3317003 to
a2f4b0f
Compare
|
This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have an internal application that uses s2n from different tasks (one for transmitting, one for receiving), and before this CR, this caused s2n to always clone the wakers and suffer from bad performance.
This change notices that the transmitted context can always be passed down the stack, and improves performance in our case by about ~5%.
If this is too ugly, maybe it is better to do it purely on our end by implementing a replacement to tokio-s2n-tls, but I'll rather use the common implementation and share the goodness.
This is unfortunately a breaking change to anyone that uses the previous waker API.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.