Skip to content

fix: enable -Wcast-qual flag for libcrypto=awslc #4735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: enable -Wcast-qual flag for libcrypto=awslc #4735

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
34ecf2c
fix: enable -Wcast-qual flag for libcrypto=awslc
Aug 26, 2024
356c721
Merge branch 'main' into fix-cast-qual
boquan-fang Apr 8, 2025
0203732
address PR comments:
Apr 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,6 +135,7 @@ target_compile_options(${PROJECT_NAME} PRIVATE
-std=gnu99
-Wall
-Wcast-align
-Wcast-qual
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this change conflicts with #5198?

If we want to continue to support older versions of AWS-LC, I'm not sure we can add this flag. Unless there's a way to check the AWS-LC version first.

-Wchar-subscripts
-Wcomment
-Wformat-security
Expand Down Expand Up @@ -232,11 +233,6 @@ endif()

list(APPEND CMAKE_MODULE_PATH "${CMAKE_CURRENT_SOURCE_DIR}/cmake/modules")

if (NOT $ENV{S2N_LIBCRYPTO} MATCHES "awslc")
# add cast-qual back in for non AWS-LC
target_compile_options(${PROJECT_NAME} PRIVATE -Wcast-qual)
endif()

if (COVERAGE)
# https://cmake.org/cmake/help/latest/variable/CMAKE_LANG_COMPILER_ID.html
# Coverage is done using LLVM source based coverage. This is only supported
Expand Down
Loading