-
Notifications
You must be signed in to change notification settings - Fork 724
ci: create .duvet/config.toml #5055
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a big PR, but I'm not seeing where these are moving to. They were manually generated because there aren't any "MUST"s in the original. Is the JA4 spec still being checked?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah I didn't realize they were done manually. I can fix those.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add more to the "Testing" section? I assume we're not supposed to review 361 files manually, so how have you confirmed that we're generating the same (or a better?) report? Especially given #5055 (comment)
f8462e1
to
fcc7920
Compare
This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Description of changes:
This change updates our duvet scripts to use the new config format from: awslabs/duvet#152.
Callouts:
I split up the changes into 2 commits. The first creates the config, updates the scripts, and moves all of the requirement files from
compliance/specs
to.duvet/requirements
: 132053bThe second commit pulls in the latest duvet extraction logic and updates the requirement files. This now preserves whitespace from the original RFC text: fcc7920
Testing:
Successful CI run here: https://github.com/aws/s2n-tls/actions/runs/12917769399/job/36024878800?pr=5055
The current mainline report is available here: https://d3fqnyekunr9xg.cloudfront.net/efb35006de554a9e9c0d74fb84e4fd74a039f144/compliance.html
Comparing the mainline report (on the left) to the new report (on the right), there is no change in requirement coverage:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.