fix: Update policy writer to print if a rule is met but not required#5732
Open
fix: Update policy writer to print if a rule is met but not required#5732
Conversation
alexw91
force-pushed
the
fix-policy-writer
branch
from
c898f56 to
28ba9d2
Compare
alexw91
changed the title
alexw91
force-pushed
the
fix-policy-writer
branch
2 times, most recently
from
cfb5f46 to
67a8374
Compare
alexw91
force-pushed
the
fix-policy-writer
branch
from
67a8374 to
faf9ce5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
Never print
Perfect Forward Secrecy: noorFIPS 140-3 (2019): noif a TLS Policy does actually meet PerfectForwardSecrecy or FIPS requirements.Why
s2n-tls users may refer to TLS Policy snapshot files when deciding which TLS Policy to use. If a snapshot file lists a
nofor a given rule when it actually does meet that rule, s2n-tls users may be confused and incorrectly choose a different TLS Policy.How
Adds an extra evaluation to the policy writer to check if a rule is met before printing
no.Callouts
None.
Testing
Manual review of TLS snapshot files.
Related
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.