Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dep): compat.py should import right pydantic class for pydantic >= 1.10.17 #3710

Merged
merged 3 commits into from
Jan 23, 2025

Conversation

roger-zhangg
Copy link
Member

Issue #, if available

#3617
pydantic/pydantic#9742

Description of changes

Update compat.py to make sure pydantic v1 should call import pydantic correctly
starting from pydantic 1.10.17, from pydantic import v1 as pydantic will not fail anymore, adding additional check to make sure pydantic v1 will run import pydantic correctly`

Description of how you validated changes

make test with pydantic 1.10.17-1.10.21

Checklist

Examples?

Please reach out in the comments if you want to add an example. Examples will be
added to sam init through aws/aws-sam-cli-app-templates.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@roger-zhangg roger-zhangg requested a review from a team as a code owner January 22, 2025 23:35
@roger-zhangg roger-zhangg changed the title chore(dep): compat.py should import right pydantic class for pydantic >= 1.10.17 fix(dep): compat.py should import right pydantic class for pydantic >= 1.10.17 Jan 22, 2025
@roger-zhangg roger-zhangg merged commit ceea00b into aws:develop Jan 23, 2025
7 checks passed
@jonringer jonringer mentioned this pull request Feb 6, 2025
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants