Modularise the repository #33
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Move packages containing entrypoints into the `cmd` package. * Move all other packages into the `pkg` package. * Declare all third-party dependencies in `go.mod`. * Update support scripts/files to handle new repository layout.
nijave
reviewed
Mar 17, 2022
|
|
||
| clean:: remove-prepacked-folder | ||
| rm -rf build/* bin/ pkg/ vendor/bin/ vendor/pkg/ .cover/ | ||
| rm -rf build/* bin/ pkg/ .cover/ |
There was a problem hiding this comment.
Suggested change
| rm -rf build/* bin/ pkg/ .cover/ | |
| rm -rf build/* bin/ .cover/ |
It looks like some files that shouldn't be cleaned up have been moved into pkg
|
Hi @chrisnovakovic, Thanks, |
|
@Yangtao-Hua Any idea when it will be merged or an answer as this would help enhance a lot of internal tooling that uses this tool. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #1
Description of changes:
In PR #11, @bwagner5 refactored the code base as a Go module. Unfortunately, there were half a dozen other unrelated changes in the same PR, which have perhaps contributed to it not being merged. This PR is limited solely to the modularisation of the code, without the other changes that you may or may not want to accept.
vendor/directory, even though this takes place in the following commit.vendor/. This is a separate commit because of how noisy the deletion of the vendorised code is compared with the changes made in the first commit.make checkstylefails, but it's currently failing on the mainline branch anyway (see #17), and it at least fails in the same way after these changes (in fact the new changes make it fail slightly less with Go 1.17). Withcheckstyleturned into a no-op in the Makefile, I was able to build working binaries withmake build-linux-amd64and a working Debian package withmake package-deb-amd64.make quick-testbehaves as expected, and passes.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.