Skip to content

Commit e5c5ac3

Browse files
committed
add changelog instructions and make recipe
1 parent 5e16ee7 commit e5c5ac3

File tree

3 files changed

+47
-0
lines changed

3 files changed

+47
-0
lines changed

CONTRIBUTING.md

+31
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,37 @@ To send us a pull request, please:
3939
GitHub provides additional document on [forking a repository](https://help.github.com/articles/fork-a-repo/) and
4040
[creating a pull request](https://help.github.com/articles/creating-a-pull-request/).
4141

42+
### Changelog Documents
43+
44+
(You can SKIP this step if you are only changing the code generator, and not the runtime).
45+
46+
When submitting a pull request please include a changelog file on a folder named `.changelog`.
47+
These are used to generate the content `CHANGELOG.md` and Release Notes. The format of the file is as follows:
48+
49+
```
50+
{
51+
"id": "12345678-1234-1234-1234-123456789012"
52+
"type": "bugfix"
53+
"collapse": true
54+
"description": "Fix improper use of printf-style functions.",
55+
"modules": [
56+
"."
57+
]
58+
}
59+
```
60+
61+
* id: a UUID. This should also be used for the name of the file, so if your id is `12345678-1234-1234-1234-123456789012` the file should be named `12345678-1234-1234-1234-123456789012.json/`
62+
* type: one of the following:
63+
* bugfix: Fixing an existing bug
64+
* Feature: Adding a new feature to an existing service
65+
* Release: Releasing a new module
66+
* Dependency: Updating dependencies
67+
* Announcement: Making an announcement, like deprecation of a module
68+
* collapse: whether this change should appear separately on the release notes on every module listed on `modules` (`"collapse": false`), or if it should show up as a single entry (`"collapse": true`)
69+
* For the smithy-go repository this should always be `false`
70+
* description: Description of this change. Most of the times is the same as the title of the PR
71+
* modules: which Go modules does this change impact. The root module is expressed as "."
72+
4273

4374
## Finding contributions to work on
4475
Looking at the existing issues is a great way to find something to contribute on. As our projects, by default, use the default GitHub issue labels (enhancement/bug/duplicate/help wanted/invalid/question/wontfix), looking at any 'help wanted' issues is a great place to start.

Makefile

+7
Original file line numberDiff line numberDiff line change
@@ -98,5 +98,12 @@ module-version:
9898
##############
9999
.PHONY: install-changelog
100100

101+
external-changelog:
102+
mkdir -p .changelog
103+
cp changelog-template.json .changelog/00000000-0000-0000-0000-000000000000.json
104+
@echo "Generate a new UUID and update the file at .changelog/00000000-0000-0000-0000-000000000000.json"
105+
@echo "Make sure to rename the file with your new id, like .changelog/12345678-1234-1234-1234-123456789012.json"
106+
@echo "See CONTRIBUTING.md 'Changelog Documents' and an example at https://github.com/aws/smithy-go/pull/543/files"
107+
101108
install-changelog:
102109
go install ${REPOTOOLS_MODULE}/cmd/changelog@${REPOTOOLS_VERSION}

changelog-template.json

+9
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
{
2+
"id": "00000000-0000-0000-0000-000000000000",
3+
"type": "feature|bugfix|dependency",
4+
"description": "Description of your changes",
5+
"collapse": false,
6+
"modules": [
7+
"."
8+
]
9+
}

0 commit comments

Comments
 (0)