Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: fix deprecated for ioutil #560

Merged
merged 4 commits into from
Jan 21, 2025

Conversation

komisan19
Copy link
Contributor

Description of changes:

Deprecated function fixes

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@komisan19 komisan19 requested review from a team as code owners December 28, 2024 17:48
@komisan19 komisan19 force-pushed the refactor/fix_deprecated_for_ioutil branch from 6ac1b9d to e06da44 Compare December 28, 2024 17:51
@lucix-aws
Copy link
Contributor

Please create a changelog entry following the workflow in https://github.com/aws/aws-sdk-go-v2/blob/main/CONTRIBUTING.md#changelog-documents (it's the SDK repo, but the process is the same).

@komisan19
Copy link
Contributor Author

komisan19 commented Jan 10, 2025

@lucix-aws
Thanks
However, I don't see the make external-changelog command in this repository.
What shoud I do?

@lucix-aws
Copy link
Contributor

Sorry, just added equivalent instructions + the make recipe in this repo: https://github.com/aws/smithy-go/blob/main/CONTRIBUTING.md#changelog-documents

@komisan19 komisan19 force-pushed the refactor/fix_deprecated_for_ioutil branch from 60e7b15 to 1fe40e4 Compare January 14, 2025 15:21
@komisan19
Copy link
Contributor Author

@lucix-aws
I have added a changelog file.
plz check it, when you have a time

@lucix-aws lucix-aws merged commit d9b8ee9 into aws:main Jan 21, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants