Add metric and span support for CBOR serialize/deserialize #566
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When doing some testing for CBOR, I realized we were not publishing metrics for serialization and deserialization. This PR fixes that.
Operation metrics are already being generated for CBOR methods as part of OperationMetricsStruct, so this just starts using them.
Note that there's no service that handles CBOR currently on the SDK, so this change won't have a corresponding change on the SDK
Testing
There are currently no methods on the SDK that directly use CBOR as their protocol, so testing was done as follows:
JSON
description to generate CBOR methodsmake generate
make
to run all testsNot sure if we have any unit or integration tests for this, but it would be nice to add them
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.