Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drop old waiters impl #573

Merged
merged 2 commits into from
Mar 5, 2025
Merged

drop old waiters impl #573

merged 2 commits into from
Mar 5, 2025

Conversation

lucix-aws
Copy link
Contributor

This is now handled by Waiters2, which does generated jmespath instead of runtime.

@lucix-aws lucix-aws requested review from a team as code owners March 5, 2025 17:39
@Madrigal
Copy link
Contributor

Madrigal commented Mar 5, 2025

can we also drop the jmespath dependency from modman.toml?

@lucix-aws
Copy link
Contributor Author

Yes good callout.

@lucix-aws lucix-aws merged commit a8203ac into main Mar 5, 2025
11 checks passed
@lucix-aws lucix-aws deleted the drop-oldwaiters branch March 5, 2025 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Madrigal Madrigal Madrigal approved these changes

@wty-Bryant wty-Bryant wty-Bryant approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lucix-aws @Madrigal @wty-Bryant