add prefix/suffix hyphen rejection for host label validation based on rfc1123#679
Open
wty-Bryant wants to merge 2 commits into
Open
add prefix/suffix hyphen rejection for host label validation based on rfc1123#679wty-Bryant wants to merge 2 commits into
wty-Bryant wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently
IsValidHostLabelin endpoint rulesfn aligns with rfc1123 to check a host label:But rfc1123 and superior 952 require the first/last char to only be alpha/numeric, and our old validation ignores hyphen rejection for that. This pr just adds that check for endpoint level host label validation without changing bottom http check
Test: run
go run ./internal/repotools/cmd/eachmodule -p . "go test ./... -run TestEndpointCase"under go v2 to make sure each service's endpoint test cases pass